Implement a function that executes an UPDATE request #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joka921
requested changes
Nov 7, 2024
Comment on lines
+52
to
+57
| auto expectExecuteUpdate = | ||
| [&executeUpdate]( | ||
| const std::string& update, | ||
| const testing::Matcher<const DeltaTriples&>& deltaTriplesMatcher) { | ||
| EXPECT_THAT(executeUpdate(update), deltaTriplesMatcher); | ||
| }; |
There was a problem hiding this comment.
This could just return a matcher (return ResultOf(executeUpdate, deltaTriplesMatcher);),
The you have the EXPECT_THAT with the single calls, and the failure messages have the correct line numbers.
test/ExecuteUpdateTest.cpp
Outdated
| const testing::Matcher<const std::vector<::IdTriple<>>&>& | ||
| toInsertMatcher, | ||
| const testing::Matcher<const std::vector<::IdTriple<>>&>& | ||
| toDeleteMatcher) { |
There was a problem hiding this comment.
See my comment above, you can also add the source_location to the matching functions and use generateLocationTrace to get better messages on failure.
Conformance check passed ✅No test result changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1607 +/- ##
==========================================
+ Coverage 89.17% 89.18% +0.01%
==========================================
Files 372 372
Lines 34579 34627 +48
Branches 3912 3915 +3
==========================================
+ Hits 30835 30882 +47
- Misses 2471 2472 +1
Partials 1273 1273 ☔ View full report in Codecov by Sentry. |
|
joka921
approved these changes
Nov 8, 2024
joka921
changed the title
hannahbast
added a commit
that referenced
this pull request
Nov 10, 2024
Since #1355, the query `LIMIT` is clamped to the value of the QLever-specific `send` parameter. In particular, this broke the display of the result size in the QLever UI, which sets `send=100` when showing the first page of results for a query. This change restores the old behavior for the `send` parameter, yet makes good use of the new lazy query processing. Specifically, lazily computed results blocks are now processed as follows: (1) the first result blocks before OFFSET are computed but skipped; (2) then results are computed and materialized until the value of the `send` parameter is reached; (3) then results are computed and counted but *not* materialized until the LIMIT is reached; (3) all remaining blocks are not even computed. The QLever JSON now has two new fields `resultSizeTotal` and `resultSizeExported`, with the corresponding values. For the sake of backwards-compatibility, the old `resultsize` field is still there and has the same value as the `resultSizeTotal` field. For the same reason, the `send` parameter keeps its name for now, but should be renamed to `exportLimit` eventually. On the side fixed, dropped the hard limit of `MAX_NOF_ROWS_IN_RESULT = 1'000'000` for JSON results. Also fix the compilation error introduced by the interplay of the merge of #1603 and #1607 . Fixes #1605 and #1455 .
ullingerc
pushed a commit
to ullingerc/qlever
that referenced
this pull request
Nov 12, 2024
This is another step towards support for `SPARQL UPDATE`. The function takes a `ParsedQuery` that contains a graph update (and UPDATE request that inserts and/or deletes triples that are computed from a WHERE clause to/from a given graph), executes the query, and passes the result to a `DeltaTriples` object.
ullingerc
pushed a commit
to ullingerc/qlever
that referenced
this pull request
Nov 12, 2024
Since ad-freiburg#1355, the query `LIMIT` is clamped to the value of the QLever-specific `send` parameter. In particular, this broke the display of the result size in the QLever UI, which sets `send=100` when showing the first page of results for a query. This change restores the old behavior for the `send` parameter, yet makes good use of the new lazy query processing. Specifically, lazily computed results blocks are now processed as follows: (1) the first result blocks before OFFSET are computed but skipped; (2) then results are computed and materialized until the value of the `send` parameter is reached; (3) then results are computed and counted but *not* materialized until the LIMIT is reached; (3) all remaining blocks are not even computed. The QLever JSON now has two new fields `resultSizeTotal` and `resultSizeExported`, with the corresponding values. For the sake of backwards-compatibility, the old `resultsize` field is still there and has the same value as the `resultSizeTotal` field. For the same reason, the `send` parameter keeps its name for now, but should be renamed to `exportLimit` eventually. On the side fixed, dropped the hard limit of `MAX_NOF_ROWS_IN_RESULT = 1'000'000` for JSON results. Also fix the compilation error introduced by the interplay of the merge of ad-freiburg#1603 and ad-freiburg#1607 . Fixes ad-freiburg#1605 and ad-freiburg#1455 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step towards support for
SPARQL UPDATE. The function takes aParsedQuerythat contains a graph update (and UPDATE request that inserts and/or deletes triples that are computed from a WHERE clause to/from a given graph), executes the query, and passes the result to aDeltaTriplesobject.