-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify CMake config and optimize includes #1618
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1618 +/- ##
==========================================
+ Coverage 89.24% 89.25% +0.01%
==========================================
Files 374 375 +1
Lines 35315 35315
Branches 3988 3988
==========================================
+ Hits 31518 31522 +4
+ Misses 2503 2501 -2
+ Partials 1294 1292 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An initial feedback.
It might be, that we throw out again FetchContent in the near future (for reasons),
But that is for another discussion.
Alsom, in the macos workflow it says env.build-type
once, and matrix.build-type
twice. It has to be always env.build-type
, thant is the issue there.
I'm pretty sure you mean it has to be |
Conformance check passed ✅No test result changes. |
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
In particular:
FETCH_CONTENT
module by using its builtin functionality instead of manual hacks (see the JSON and ANTLR dependencies for details).