Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CMake config and optimize includes #1618

Merged
merged 15 commits into from
Nov 18, 2024

Conversation

RobinTF
Copy link
Collaborator

@RobinTF RobinTF commented Nov 15, 2024

In particular:

  • Clean up the usage of the FETCH_CONTENT module by using its builtin functionality instead of manual hacks (see the JSON and ANTLR dependencies for details).
  • Make the includes of the ANTLR and ABSL submodules (which use macros that collide with our own) more robust.

@RobinTF RobinTF changed the title Simplify CMake config and optimize imports Simplify CMake config and optimize includes Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.25%. Comparing base (77ac964) to head (9937811).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1618      +/-   ##
==========================================
+ Coverage   89.24%   89.25%   +0.01%     
==========================================
  Files         374      375       +1     
  Lines       35315    35315              
  Branches     3988     3988              
==========================================
+ Hits        31518    31522       +4     
+ Misses       2503     2501       -2     
+ Partials     1294     1292       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An initial feedback.
It might be, that we throw out again FetchContent in the near future (for reasons),
But that is for another discussion.

Alsom, in the macos workflow it says env.build-type once, and matrix.build-type twice. It has to be always env.build-type, thant is the issue there.

CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
@RobinTF
Copy link
Collaborator Author

RobinTF commented Nov 15, 2024

@joka921

Alsom, in the macos workflow it says env.build-type once, and matrix.build-type twice. It has to be always env.build-type, thant is the issue there.

I'm pretty sure you mean it has to be matrix.build-type

@sparql-conformance
Copy link

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@joka921 joka921 merged commit daf2c30 into ad-freiburg:master Nov 18, 2024
21 of 22 checks passed
@RobinTF RobinTF deleted the cmake-update branch November 18, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants