-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the hash map group by lazy #1651
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1651 +/- ##
==========================================
+ Coverage 89.84% 89.87% +0.02%
==========================================
Files 389 389
Lines 37268 37287 +19
Branches 4202 4204 +2
==========================================
+ Hits 33482 33510 +28
+ Misses 2485 2478 -7
+ Partials 1301 1299 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works fine in some test queries we tried. Minor change left.
Signed-off-by: Johannes Kalmbach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
As a follow-up, we should find a way to enable this automatically, in particular, for queries like SELECT ?g (COUNT(?g) AS ?count) WHERE { GRAPH ?g { ?s ?p ?o } } GROUP BY ?g
Conformance check passed ✅No test result changes. |
Quality Gate passedIssues Measures |
No description provided.