Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further reduce the size of the Docker image #1658

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

Qup42
Copy link
Member

@Qup42 Qup42 commented Dec 4, 2024

Remove ppa:mhier/libboost-latest (no longer needed to install the Boost packages), move some more packages that are only needed for compiling to the respective stage (so that they don't end up in the final image), use the non-dev version of packages in the final image, and only install those Boost packages that are needed to run Qlever. This about halves the image size from almost 800 MB previously to now 400 MB.

@Qup42
Copy link
Member Author

Qup42 commented Dec 4, 2024

What's the reason for including the e2e Test in the image?

@sparql-conformance
Copy link

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (392b0e3) to head (3004b63).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1658   +/-   ##
=======================================
  Coverage   89.57%   89.58%           
=======================================
  Files         381      381           
  Lines       36792    36811   +19     
  Branches     4170     4172    +2     
=======================================
+ Hits        32958    32977   +19     
  Misses       2522     2522           
  Partials     1312     1312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hannahbast hannahbast changed the title Optimise dockerfile Further reduce the size of the Docker image Dec 4, 2024
@hannahbast hannahbast marked this pull request as ready for review December 4, 2024 17:54
Copy link

sonarqubecloud bot commented Dec 4, 2024

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot!

Interestingly, installing libboost...1.83.0 instead of libboost...1.83 made most of the difference, whereas installing the non-dev versions of jemalloc, libztsd, and libicu made hardly any difference.

@hannahbast hannahbast merged commit 23f8075 into ad-freiburg:master Dec 4, 2024
23 checks passed
@Qup42 Qup42 deleted the optimiseDockerfile branch December 6, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants