Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precomputation for SERVICE in JOIN operation #1661

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

UNEXENU
Copy link
Contributor

@UNEXENU UNEXENU commented Dec 5, 2024

This fixes #1659, an issue introduced in #1556 that made the precomputation of a SERVICE sibling in JOIN operations impossible.

@sparql-conformance
Copy link

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.56%. Comparing base (ec806f0) to head (5be697c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1661      +/-   ##
==========================================
- Coverage   89.58%   89.56%   -0.02%     
==========================================
  Files         381      381              
  Lines       36813    36813              
  Branches     4173     4173              
==========================================
- Hits        32978    32972       -6     
- Misses       2523     2524       +1     
- Partials     1312     1317       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 5, 2024

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this fix, @hannahbast has tried it out and confirmed, that it works as expected.

@joka921 joka921 merged commit c76f24b into ad-freiburg:master Dec 6, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SERVICE with constrained outside no longer uses that constraint
2 participants