Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow operations to not store their result in the cache #1665

Merged

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Dec 5, 2024

Each operation now has a bool that determines whether the results can be stored in the cache or not (whether it is actually stored depends on other circumstances, like the available cache size). That bool does not have to be fixed when the operation is created, but can be changed.

For example, this is useful for index scans that only return a subset of their full result (because of another constraining operation, like a join or a filter).

Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.68%. Comparing base (ec806f0) to head (4064a85).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/engine/Operation.cpp 93.10% 1 Missing and 1 partial ⚠️
src/util/ConcurrentCache.h 84.61% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1665      +/-   ##
==========================================
+ Coverage   89.58%   89.68%   +0.09%     
==========================================
  Files         381      383       +2     
  Lines       36813    36962     +149     
  Branches     4173     4178       +5     
==========================================
+ Hits        32978    33148     +170     
+ Misses       2523     2515       -8     
+ Partials     1312     1299      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-1 with Johannes, looks great, some minor changes

Signed-off-by: Johannes Kalmbach <[email protected]>
@sparql-conformance
Copy link

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I wrote a description and will merge this once all the checks are green

@hannahbast hannahbast merged commit 70964d6 into ad-freiburg:master Dec 12, 2024
21 checks passed
@joka921 joka921 deleted the explicitly-disable-caching-of-operations branch December 18, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants