-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow operations to not store their result in the cache #1665
Allow operations to not store their result in the cache #1665
Conversation
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1665 +/- ##
==========================================
+ Coverage 89.58% 89.68% +0.09%
==========================================
Files 381 383 +2
Lines 36813 36962 +149
Branches 4173 4178 +5
==========================================
+ Hits 32978 33148 +170
+ Misses 2523 2515 -8
+ Partials 1312 1299 -13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1-1 with Johannes, looks great, some minor changes
Signed-off-by: Johannes Kalmbach <[email protected]>
Conformance check passed ✅No test result changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I wrote a description and will merge this once all the checks are green
Quality Gate passedIssues Measures |
Each operation now has a
bool
that determines whether the results can be stored in the cache or not (whether it is actually stored depends on other circumstances, like the available cache size). Thatbool
does not have to be fixed when the operation is created, but can be changed.For example, this is useful for index scans that only return a subset of their full result (because of another constraining operation, like a join or a filter).