C17 Otters - Natalya and Lin #38

lin6692 · 2022-03-31T20:24:47Z

No description provided.

jbieniosek

Great work on this project Natalya and Lin! The code is very clean and readable. Nice work with your frequent commits! This project is green.

jbieniosek · 2022-04-08T17:19:22Z

adagrams/game.py

+            del letter_pool_copy[letter]       
+        else:
+            letter_pool_copy[letter] -= 1
+        drawn_letters.append(letter)


Great solution!

jbieniosek · 2022-04-08T17:20:48Z

adagrams/game.py

+    for char in word:                               
+        if char not in letter_bank_copy:        
+            return False            
+        letter_bank_copy.remove(char)               


jbieniosek · 2022-04-08T17:28:55Z

adagrams/game.py

+        for char, value in SCORE_CHART.items():    
+            if letter in char:                     
+                score += value


The dictionary structure of SCORE_CHART is not optimal for this problem. The setup here with tuples as keys makes it necessary to search for the letter, but a dictionary where each letter is a key and the point value is the dictionary value would remove the need for this inner loop.

jbieniosek · 2022-04-08T17:30:24Z

adagrams/game.py

+
+    # Create a list of all words that have the highest score.
+    words_max_value = [word for word, score in words_score.items() if score == max_value]


jbieniosek · 2022-04-08T17:34:31Z

adagrams/game.py

+        # in all other cases return the first word in the list words_max_value as it has the fewest letters.
+    if len(words_max_value) > 1: 
+        words_max_value = sorted(words_max_value, key=len)


This works because the function sorted is a stable sort function (https://docs.python.org/3/library/functions.html#sorted). From the linked doc:

The built-in sorted() function is guaranteed to be stable. A sort is stable if it guarantees not to change the relative order of elements that compare equal — this is helpful for sorting in multiple passes (for example, sort by department, then by salary grade).

jbieniosek · 2022-04-08T17:35:29Z

adagrams/game.py

+            if len(word) == 10:
+                return word, max_value  
+    return words_max_value[0], max_value


Great solution!

lin6692 and others added 8 commits March 29, 2022 10:07

define the function draw_letters

a3204c8

Define the function uses_available_letters

ef59983

define function score_word

3969555

Define the function get_highest_word_score

b16b279

add comments for refactoring

df7a175

Refactored the functions and added comments.

1a5e6ea

erge

aa0a8d7

solve merge conflict

bc57f38

jbieniosek reviewed Apr 8, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

C17 Otters - Natalya and Lin #38

C17 Otters - Natalya and Lin #38

lin6692 commented Mar 31, 2022

jbieniosek left a comment

jbieniosek Apr 8, 2022

jbieniosek Apr 8, 2022

jbieniosek Apr 8, 2022

jbieniosek Apr 8, 2022

jbieniosek Apr 8, 2022

jbieniosek Apr 8, 2022


		# Create a list of all words that have the highest score.
		words_max_value = [word for word, score in words_score.items() if score == max_value]

C17 Otters - Natalya and Lin #38

Are you sure you want to change the base?

C17 Otters - Natalya and Lin #38

Conversation

lin6692 commented Mar 31, 2022

jbieniosek left a comment

Choose a reason for hiding this comment

jbieniosek Apr 8, 2022

Choose a reason for hiding this comment

jbieniosek Apr 8, 2022

Choose a reason for hiding this comment

jbieniosek Apr 8, 2022

Choose a reason for hiding this comment

jbieniosek Apr 8, 2022

Choose a reason for hiding this comment

jbieniosek Apr 8, 2022

Choose a reason for hiding this comment

jbieniosek Apr 8, 2022

Choose a reason for hiding this comment