Sea Turtles - Adriana Gutierrez, Esther Annorzie, Joanna Dudley, & Lili Parra #25
Conversation
…f board_id, fixed
| if data_dict.keys() == cls.required_attributes.keys(): | ||
| return cls(title=data_dict["title"], owner=data_dict["owner"]) | ||
| else: | ||
| remaining_keys= set(data_dict.keys())-set("title", "owner") | ||
| response=list(remaining_keys) | ||
| raise ValueError(response) |
There was a problem hiding this comment.
Depending on your project, if a user sends an extra key along with the required data for an operation, you may want to still create an object with that valid info and maybe share a message that non-required keys were not be used. There's no right or wrong in this case, just something to think about when designing endpoints.
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Love all the helper functions!
| def update_self(self, data_dict): | ||
| dict_key_errors = [] | ||
| for key in data_dict.keys(): | ||
| if hasattr(self, key): | ||
| setattr(self, key, data_dict[key]) | ||
| else: | ||
| dict_key_errors.append(key) | ||
| if dict_key_errors: | ||
| raise ValueError(dict_key_errors) |
There was a problem hiding this comment.
I think we could cut down on duplication of the identical update_self instance functions each of the classes implements. Looking at where self is used, I believe this could be moved to the helper functions file shared amongst the classes if the first parameter was the instance variable to be updated rather than self.
| error_message("Message not found", 400) | ||
|
|
||
| request_body["board_id"] = board_id | ||
| card = Card.create_from_dict(request_body) |
There was a problem hiding this comment.
Could we also use the helper create_record_safely here?
| assert response.status_code == 200 | ||
| assert response_body == [] | ||
|
|
||
| def test_get_one_board_with_cards(client, one_board_no_cards): |
There was a problem hiding this comment.
I think it's important to be really clear about what we are testing with our naming. This tests takes in a board with no cards, adds 2 cards, then fetches it to check the contents. To me, the adding cards portion is important to note, since we are executing additional code than if we had a test which passed in a fixture of a board that already had 2 cards attached to it and immediately fetched that board.
No description provided.