Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge sorted #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Merge sorted #9

wants to merge 2 commits into from

Conversation

VidaMaleki
Copy link

please check merge sorted

tetianazakipna
tetianazakipna reviewed May 12, 2022
View reviewed changes
Copy link

@tetianazakipna tetianazakipna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, Vida!

functions/merge_sorted_lists.py
@@ -1,2 +1,3 @@
def merge_sorted_lists(l1, l2):
pass
merged = l1 + l2
return sorted(merged)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart decision!

tests/merge_sorted_lists_test.py
assert answer == [1, 2]


def test_for_2_and_1():
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart test

tests/merge_sorted_lists_test.py
answer = merge_sorted_lists(l1, l2)

# Assert
assert answer == [1, 2, 3, 4, 5, 6]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool assert

@tetianazakipna
Copy link

I accept this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetianazakipna tetianazakipna tetianazakipna left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VidaMaleki @tetianazakipna