Tien&Anya - Sharks Solar_system #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spitsfire
reviewed
May 9, 2022
Comment on lines
+14
to
+15
| # app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False | ||
| # app.config['SQLALCHEMY_DATABASE_URI'] = 'postgresql+psycopg2://postgres:postgres@localhost:5432/solar_system_development' |
There was a problem hiding this comment.
since we now have this string stored in our environmental variables for safe keeping we want to get rid of it from public view
Suggested change
| # app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False | |
| # app.config['SQLALCHEMY_DATABASE_URI'] = 'postgresql+psycopg2://postgres:postgres@localhost:5432/solar_system_development' |
There was a problem hiding this comment.
Agree, should be deleted from init.py
| @@ -0,0 +1,15 @@ | |||
| from flask import abort, make_response | |||
There was a problem hiding this comment.
👍 Great job moving this helper function into a separate file, so that our routes are more clean and easy to read!
Comment on lines
+34
to
+47
| # class Planet(): | ||
| # def __init__(self, id, name, description, moons = None): | ||
| # self.id = id | ||
| # self.name = name | ||
| # self.description = description | ||
| # self.moons = moons | ||
|
|
||
| # def to_json(self): | ||
| # return { | ||
| # "id": self.id, | ||
| # "name" : self.name, | ||
| # "decription": self.description, | ||
| # "moons": self.moons | ||
| # } |
There was a problem hiding this comment.
Suggested change
| # class Planet(): | |
| # def __init__(self, id, name, description, moons = None): | |
| # self.id = id | |
| # self.name = name | |
| # self.description = description | |
| # self.moons = moons | |
| # def to_json(self): | |
| # return { | |
| # "id": self.id, | |
| # "name" : self.name, | |
| # "decription": self.description, | |
| # "moons": self.moons | |
| # } |
| "moons": self.moons | ||
| } | ||
|
|
||
| def update(self, req_body): |
| db.session.add(new_planet) | ||
| db.session.commit() | ||
|
|
||
| # return make_response(jsonify(f"Planet {new_planet.name} successfully created!", 201)) |
There was a problem hiding this comment.
This looks the same as the one below, so let's get rid of this
Suggested change
| # return make_response(jsonify(f"Planet {new_planet.name} successfully created!", 201)) |
Comment on lines
+41
to
+42
| # return jsonify(planet.to_json()), 200 | ||
| return jsonify(planet.to_json()) |
There was a problem hiding this comment.
any reason you removed the status code on line 42?
There was a problem hiding this comment.
I think no. I am not sure why we removed it.
| @@ -0,0 +1,42 @@ | |||
| import pytest | |||
| @@ -0,0 +1,45 @@ | |||
| def test_get_all_planets_with_no_records(client): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.