update #77
update #77
Conversation
|
|
||
| <h3>Select City Name</h3> | ||
| <select id=".timeDiv"> | ||
| <input type="text" id="city-input" value="City Name Here"/> | ||
| <h3>Reset City:</h3> | ||
| <button id="city-reset">Reset Me</button> | ||
| </select> | ||
|
|
||
| </section> |
There was a problem hiding this comment.
I think you are missing the opening section tag for line 52 it should be on line 44.
|
|
||
| <section class="divTwo"> | ||
| <h3>Thermostat</h3> | ||
| <div class=".adhDiv"> |
There was a problem hiding this comment.
You did a good job using the section tag to organize your webpage. I want to share this resource on the flow for what tags to use. Hopefully, it will be helpful on when to use divs and when not to
o
| const incTemp = document.querySelector("#increase-temp"); | ||
| const decTemp = document.querySelector("#decrease-temp"); | ||
| const tempDisplay = document.querySelector("#temp-display"); | ||
| const landscape = document.querySelector("#landscape"); |
There was a problem hiding this comment.
putting your query selectors here I think is helpful!
|
|
||
| let temp = 70; | ||
|
|
||
| const tempColors = () => { |
| } | ||
| }; | ||
|
|
||
| const tempLand = () => { |
|
|
||
| }; | ||
|
|
||
| const registerEventHandlers = () => { |
|
|
||
| const resetButton = document.querySelector("#city-reset") | ||
| resetButton.addEventListener("click", reset); | ||
|
|
There was a problem hiding this comment.
you are missing your functions to make the API calls to get the accurate weather. Think about where on your app you would want to add a button to get the current cities actual weather
| padding-top: 30px; | ||
| padding-bottom: 30px; |
There was a problem hiding this comment.
you can write padding on one line like padding: 30px 0px 30px 0px
the order is padding: top left bottom right
No description provided.