implement URLPattern #785
implement URLPattern #785
Conversation
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
from
89f46f0 to
02492e1
Compare
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
from
0ccd6d3 to
d2cd4f8
Compare
|
@anonrig Just to confirm... is this the spec? https://urlpattern.spec.whatwg.org |
Yes that's correct @lemire |
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
3 times, most recently
from
e51503f to
524cb73
Compare
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
from
1a98cc9 to
18ef1a6
Compare
|
I don't particular mind, but please be aware that you are changing the coding convention. The C++ standard library uses all-lowercase with underscores names. You are using Camel case. If you merge this, it will mean that within the same library, we mix two conventions. |
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
3 times, most recently
from
380d57e to
880e260
Compare
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
5 times, most recently
from
51690eb to
010bc69
Compare
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
2 times, most recently
from
bf191ce to
ce6c27d
Compare
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
from
ce6c27d to
e7c580d
Compare
| } | ||
|
|
||
| template <url_pattern_encoding_callback F> | ||
| Token* url_pattern_parser<F>::try_consume_modifier_token() { |
There was a problem hiding this comment.
You are returning a pointer to an instance of Token here. Who owns the Token instance? I recommend documenting it.
| } | ||
|
|
||
| template <url_pattern_encoding_callback F> | ||
| Token* url_pattern_parser<F>::try_consume_regexp_or_wildcard_token( |
There was a problem hiding this comment.
I recommend documenting who owns the pointer to a Token instance here.
| } | ||
|
|
||
| template <url_pattern_encoding_callback F> | ||
| Token* url_pattern_parser<F>::try_consume_token(token_type type) { |
There was a problem hiding this comment.
I recommend documenting who owns the pointer to a Token instance here.
|
|
||
| // @see https://urlpattern.spec.whatwg.org/#pattern-parser | ||
| template <url_pattern_encoding_callback F> | ||
| class url_pattern_parser { |
There was a problem hiding this comment.
Instance of the template class url_pattern_parser appear to own tokens. We want to make sure that the token pointers never survive beyond the lifetime of their originator.
src/url_pattern_helpers.cpp
Outdated
| // Let parser be a new pattern parser whose encoding callback is encoding | ||
| // callback and segment wildcard regexp is the result of running generate a | ||
| // segment wildcard regexp given options. | ||
| auto parser = url_pattern_parser<F>( |
There was a problem hiding this comment.
The parser's scope is limited to this function, this means that the pointers to the token we generate within this function only lives for the duration of the function. We need to make sure that this is not a problem. It should be documented that no pointer to a token escapes this function.
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
2 times, most recently
from
f76e3ee to
c3adedb
Compare
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
from
c3adedb to
674c0bb
Compare
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
2 times, most recently
from
1e8c75f to
8292933
Compare
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
from
8292933 to
3aad757
Compare
anonrig
force-pushed
the
yagiz/add-url-pattern
branch
from
ccd1734 to
c0db9c8
Compare
This implements URLPattern from scratch. I'm adding
TODO: Optimization opportunitynotes in places I think an optimization can be done. The goal is to merge this once there is noTODO: Implement thiscomments.TODOs
TODO: Implement thisoccurrences (currently 4)url_pattern::match