Implemented IR rawSend in IRsend class #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I noticed there is no implemented support for sending raw IR data.
The relevant function is written in IRLib_HashRaw.h, which had no include statement in IRLibCPE.h, and in addition the only linkage was broken:
The next line is a line is in IRLib_HashRaw.h:
#define IR_SEND_RAW case 0: IRsendRaw::send((uint16_t*)data,data2,khz); break;
The IR_SEND_RAW macro is used in IRLibCombo.h in IRsend class, in the send method, in order to send raw transmission. That will always result as an illegal cast between uint32_t to uint16_t* .
As a result it's impossible to use this method from the built-in IRsend object in the main object of CircuitPlayground.
IMO the send raw functionality should be separated from the other IR send's functionality as it receives different parameters.
Hope that helps :)
Idan