Teensy 4 should use fast SPI like T3.x, not 8 MHz like Teensy 2.x #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natecermak
changed the title
natecermak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if one were using this library with a Teensy 4.0 or 4.1, it would use the Teensy 2 SPI speed of 8 MHz because the code was written before T4 existed, and
TEENSYDUINOis still defined. However, Teensy 4.x is faster than T3.x, and should at minimum use the same speed as T3.x (40 MHz). This PR fixes that.Empirically I tested an ILI9341 display with 80MHz on the teensy 4.1 and it handled that fine too -- happy to change the define to that too if anyone feels it necessary (although i havent verified the chip is spec'd to operate at that speed, and that will make more sensitive to trace capacitance).