arduino simpletest for the vcnl4200 #2926
Conversation
TProgmemRGBGradientPalettePtr was replaced with TProgmemRGBGradientPaletteRef
| uint16_t alsData = vcnl4200.readALSdata(); | ||
| Serial.print("ALS Data: "); | ||
| Serial.print(alsData); | ||
| uint16_t whiteData = vcnl4200.readWhiteData(); |
There was a problem hiding this comment.
Add comment:
// Read the raw white sensor data
to match comment on L39
There was a problem hiding this comment.
@BlitzCityDIY The refactor for FastLED looks good. I left one optional comment, you may accept or reject it as it does not affect the program itself.
LGTM
|
@brentru awesome, thanks! that makes sense about the comment, will add. |
|
Sounds good - comments like this make the loop code appear more symmetrical. |
| @@ -286,7 +286,7 @@ void swirly() | |||
| // blur it repeatedly. Since the blurring is 'lossy', there's | |||
| // an automatic trend toward black -- by design. | |||
| uint8_t blurAmount = beatsin8(2,10,255); | |||
| blur2d( leds, kMatrixWidth, kMatrixHeight, blurAmount); | |||
There was a problem hiding this comment.
I know we're both just making guesses here but I think this is going to change the result of blur2d.
I went back into the fastled history to see how this worked before and after:
FastLED/FastLED@b02a481#diff-6b91d9b6efd432b06dc6eb73a57f6a29d64d6b6983c760779f9e86099d8ddafdL465
Previously, blur2d used the XY function provided in the sketch, this was implicit. So the blur would be using the structure of the disco jacket as defined in the Jacket Table.
After this change, the XY function is not used by blur (though it is used elsewhere through the file), but instead a serpentine mapping defined by myXYMap would be used.
I think that constructWithUserFunction() probably needs to be used, something like: XYMap myXYMap = XYMap::constructWithUserFunction(kMatrixWidth, kMatrixHeight, XY)
The result of an incorrect pixel map is that values from one area of the jacket would blur into non-adjacent pixels, making the effect look more muddled.
There was a problem hiding this comment.
very good catch and i was concerned about that one. i just pushed an update that uses constructWithUserFunction(). i hooked up two neopixel matrices and a button to test and compare to the project video and i believe that functionality has been retained
change pins that were used for testing back to documented pins
|
Thanks! |
arduino simpletest for the vcnl4200. reads lux, white light and proximity data