port for WeAct Studio H723VG-LCD dev board #9550
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshewan
force-pushed
the
weact-h723vg-lcd-port
branch
3 times, most recently
from
5bef472
to
cec4a45
Compare
bshewan
force-pushed
the
weact-h723vg-lcd-port
branch
from
cec4a45
to
6004174
Compare
tannewt
requested changes
Aug 27, 2024
| @@ -80,7 +80,7 @@ SECTIONS | |||
| _ld_d1_ram_bss_start = ADDR(.bss); | |||
| _ld_d1_ram_bss_size = SIZEOF(.bss); | |||
| _ld_heap_start = _ld_d1_ram_bss_start + _ld_d1_ram_bss_size; | |||
| _ld_heap_end = ORIGIN(RAM) + LENGTH(RAM); | |||
| _ld_heap_end = ORIGIN(RAM) + LENGTH(RAM) - 1; | |||
There was a problem hiding this comment.
What is the last byte used for?
Comment on lines
+1
to
+2
| USB_VID = 0x0483 | ||
| USB_PID = 0x5740 |
There was a problem hiding this comment.
This is a generic STM VID/PID. If you don't work for WeAct you can request a USB PID from: https://pid.codes/ If you do work for WeAct, then you should sublicense a unique PID from STM or acquire your own VID from the USB folks.
| @@ -37,7 +37,7 @@ extern "C" { | |||
| * (when HSE is used as system clock source, directly or through the PLL). | |||
| */ | |||
| #if !defined(HSE_VALUE) | |||
| #define HSE_VALUE ((uint32_t)8000000) /*!< Value of the External oscillator in Hz : FPGA case fixed to 60MHZ */ | |||
| #define HSE_VALUE ((uint32_t)25000000) /*!< Value of the External oscillator in Hz : FPGA case fixed to 60MHZ */ | |||
There was a problem hiding this comment.
Why change the default? Shouldn't the board define this?
| @@ -44,12 +48,12 @@ void stm32_peripherals_clocks_init(void) { | |||
| RCC_OscInitStruct.HSEState = BOARD_HSE_SOURCE; | |||
| RCC_OscInitStruct.PLL.PLLState = RCC_PLL_ON; | |||
| RCC_OscInitStruct.PLL.PLLSource = RCC_PLLSOURCE_HSE; | |||
| RCC_OscInitStruct.PLL.PLLM = HSE_VALUE / 2000000; | |||
| RCC_OscInitStruct.PLL.PLLM = 2; | |||
There was a problem hiding this comment.
Does this break other H7 boards?
| @@ -185,7 +185,7 @@ void port_internal_flash_flush(void) { | |||
| uint32_t sector_size; | |||
| uint32_t sector_start_addr = 0xffffffff; | |||
| #if defined(STM32H7) | |||
| EraseInitStruct.Banks = get_bank(_cache_flash_addr); | |||
| // EraseInitStruct.Banks = get_bank(_cache_flash_addr); | |||
Comment on lines
-119
to
+130
| __HAL_RCC_USB2_OTG_FS_CLK_ENABLE(); | ||
| __HAL_RCC_USB_OTG_HS_CLK_ENABLE(); |
There was a problem hiding this comment.
Do some H7 have two USB peripherals? The board should probably configure which to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port for this board: https://github.com/WeActStudio/WeActStudio.MiniSTM32H723