validation/microdeposits: add a config for withdrawing from savings a…

…ccounts

Issue: moov-io#541

docs/config.md

@@ -251,6 +251,10 @@ pipeline:
 validation:
   microDeposits:
     [ sameyDay: <boolean> ]
+    withdraw:
+      # Regulation D from the Federal Reserve limits withdraws from savings accounts
+      # to six per month with fees for extra withdraws. This has been temporarily suspended in 2020.
+      [ fromSavingsAccounts: <boolean> ]
     source:
       # ID from the Customers service for the source of micro-deposit funds
       customerID: <string>

pkg/config/validation.go

@@ -20,14 +20,14 @@ func (cfg Validation) Validate() error {
 }
 
 type MicroDeposits struct {
-	Source Source
+	SameDay  bool
+	Withdraw MicroDepositWithdraw
+	Source   Source
 
 	// Description is the default for what appears in the Online Banking
 	// system for end-users of PayGate. Per NACHA limits this is restricted
 	// to 10 characters.
 	Description string
-
-	SameDay bool
 }
 
 func (cfg *MicroDeposits) Validate() error {
@@ -40,6 +40,10 @@ func (cfg *MicroDeposits) Validate() error {
 	return nil
 }
 
+type MicroDepositWithdraw struct {
+	FromSavingsAccounts bool
+}
+
 type Source struct {
 	CustomerID string
 	AccountID  string

pkg/validation/microdeposits/micro_deposits.go

@@ -8,9 +8,11 @@ import (
 	"crypto/rand"
 	"fmt"
 	"math/big"
+	"strings"
 	"time"
 
 	"github.com/moov-io/base"
+	customers "github.com/moov-io/customers/client"
 	"github.com/moov-io/paygate/pkg/client"
 	"github.com/moov-io/paygate/pkg/config"
 	"github.com/moov-io/paygate/pkg/customers/accounts"
@@ -57,6 +59,11 @@ func createMicroDeposits(
 		micro.TransferIDs = append(micro.TransferIDs, xfer.TransferID)
 	}
 
+	// skip the debit for Savings accounts when configured to do so
+	if skipDebit(cfg.Withdraw, dest.Account) {
+		return micro, nil
+	}
+
 	// originate the debit
 	sum, err := model.SumAmounts(amt1, amt2)
 	if err != nil {
@@ -75,6 +82,11 @@ func createMicroDeposits(
 	return micro, nil
 }
 
+func skipDebit(cfg config.MicroDepositWithdraw, acct customers.Account) bool {
+	isSavingsAccount := strings.EqualFold(string(acct.Type), string(customers.SAVINGS))
+	return isSavingsAccount && cfg.FromSavingsAccounts
+}
+
 func getMicroDepositAmounts() (string, string) {
 	random := func() string {
 		n, _ := rand.Int(rand.Reader, big.NewInt(25)) // rand.Int returns [0, N)

pkg/validation/microdeposits/micro_deposits_test.go

@@ -59,6 +59,24 @@ func TestAmounts(t *testing.T) {
 	}
 }
 
+func TestSkipDebit(t *testing.T) {
+	cfg := config.MicroDepositWithdraw{
+		FromSavingsAccounts: true,
+	}
+	acct := customers.Account{
+		Type: customers.SAVINGS,
+	}
+	if !skipDebit(cfg, acct) {
+		t.Error("expected to skip deibt")
+	}
+
+	// don't skip for Checking accounts
+	acct.Type = customers.CHECKING
+	if skipDebit(cfg, acct) {
+		t.Error("expected no skip")
+	}
+}
+
 func TestMicroDeposits__createMicroDeposits(t *testing.T) {
 	cfg := mockConfig()
 	cfg.ODFI.RoutingNumber = "123456780"