On ongoing branch of making everything async #565
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
adamhathcock
commented
Feb 1, 2021
•
adamhathcock
commented
- Use ReadAsync/WriteAsync on every stream
- Use CancelationToken (drop Listener interface?)
- Use ValueToken (need to find better Task.Completed version)
- Use IAsyncDisposable (drop IDispose as it mostly doesn't apply)
- Use IAsyncEnumerable
- Some usage of Memory/Span. Usage of MemoryPool seem good but don't want to completely convert yet.
- More?
JanHyka
reviewed
Feb 1, 2021
| @@ -137,11 +139,11 @@ private bool DoesKeyMatchExisting(string key) | |||
| return false; | |||
| } | |||
|
|
|||
| public void SaveTo(Stream stream, WriterOptions options) | |||
| public async Task SaveToAsync(Stream stream, WriterOptions options) | |||
There was a problem hiding this comment.
CancellationToken parameter should be passed through whole call chain and exposed to library consumers (as non-mandatory parameter on top level). Otherwise caller won't be able to cancel running operation (timeouts).
There was a problem hiding this comment.
It's definitely something I want to do. I might miss more. Need to find a Rider plugin to help me catch it.
# Conflicts: # src/SharpCompress/Archives/GZip/GZipArchive.cs # src/SharpCompress/Common/GZip/GZipFilePart.cs # src/SharpCompress/Common/Tar/Headers/TarHeader.cs # src/SharpCompress/Common/Zip/SeekableZipHeaderFactory.cs # src/SharpCompress/Common/Zip/ZipFilePart.cs # src/SharpCompress/Compressors/Deflate/ZlibBaseStream.cs # src/SharpCompress/Compressors/LZMA/LZipStream.cs # src/SharpCompress/Compressors/Xz/BinaryUtils.cs # src/SharpCompress/Compressors/Xz/Crc32.cs # src/SharpCompress/Writers/Tar/TarWriter.cs # src/SharpCompress/Writers/Zip/ZipCentralDirectoryEntry.cs # src/SharpCompress/Writers/Zip/ZipWriter.cs
|
is there any plan on continuing this work? |
|
Not from me anytime soon as my personal and professional life is too busy. Sorry. |
|
Hi. Can we expect asynchrony support in the near future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.