Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zstandard support #627

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Zstandard support #627

wants to merge 3 commits into from

Conversation

adamhathcock
Copy link
Owner

No description provided.

@adamhathcock
Copy link
Owner Author

Looks like Fody rewriting somehow breaks a RAR class :(

@Nanook
Copy link
Collaborator

Nanook commented May 3, 2022

I've not looked at the detail of this change. Will it add zstd to zip/zipx and 7zip reading, plus encode/decode blocks/streams? How complete is it? I'm interested in having this functionality.

Thanks.

@adamhathcock
Copy link
Owner Author

It's not very complete mainly because the implementation used Fody as code generator and I couldn't quite get it right.

You taking over this would be perfect. I'd rather not use code weaving to be honest but can't recall if other implementations exist.

@Nanook
Copy link
Collaborator

Nanook commented May 3, 2022

Are you using https://github.com/oleg-st/ZstdSharp ? I can't divert any more time away from my project just yet, but at some point in the coming months I would like to I'd like to have this implemented ;-)

Edit: Yes I can see the Issue mentioning it ;-)

@adamhathcock
Copy link
Owner Author

👍 looking forward to it...no rush. I tried emailing about formalizing you as a maintainer or whatever but I guess that didn't work or I got the wrong email

Github has no direct message 🤔

@Nanook
Copy link
Collaborator

Nanook commented May 3, 2022

Nice one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants