Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for 7zip SFX archives #860

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Added support for 7zip SFX archives #860

merged 1 commit into from
Aug 6, 2024

Conversation

lostmsu
Copy link
Contributor

@lostmsu lostmsu commented Aug 3, 2024

Scans for magic header when ReaderOptions.LookForHeader is set

@adamhathcock
Copy link
Owner

run dotnet csharpier . after refreshing the tools to get the formatting please

not sure I grasp why AutoArchiveFactory is needed but looks good to me if tests pass

@lostmsu
Copy link
Contributor Author

lostmsu commented Aug 6, 2024

AutoArchiveFactory allows to unify tests with or without IArchiveFactory provided (e.g. if none - auto is used). I assume it could be useful in other scenarios too.

adamhathcock
adamhathcock approved these changes Aug 6, 2024
View reviewed changes
Copy link
Owner

@adamhathcock adamhathcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adamhathcock adamhathcock enabled auto-merge August 6, 2024 07:51
@adamhathcock adamhathcock merged commit 2d13bc0 into adamhathcock:master Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamhathcock adamhathcock adamhathcock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lostmsu @adamhathcock