Skip to content
This repository has been archived by the owner on Feb 26, 2018. It is now read-only.

add phpdoc to every method for autocompletion #110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bussnet
Copy link

@bussnet bussnet commented Jul 5, 2016

add phpdoc for the methods, so with the barryvdh/laravel-ide-helper there is autocompletion with IDEs like PhpStorm

@coveralls
Copy link

coveralls commented Jul 5, 2016

Coverage Status

Coverage increased (+0.03%) to 90.909% when pulling 9abc0d3 on bussnet:master into c11c418 on adamwathan:master.

@Tjoosten
Copy link

I think it could be handy if you adc the data type also.

@bussnet
Copy link
Author

bussnet commented Jul 24, 2016

@Tjoosten What do you mean? What datatypes at what position?

@adamwathan Are you willing to merge this pull request? For us these changes are very important, cause the development time decreases extremly.
Otherwise we use our own forked repository.

@Tjoosten
Copy link

Example:

/**

  • int $id
    */

2016-07-24 8:11 GMT+02:00 bussnet [email protected]:

@Tjoosten https://github.com/Tjoosten What do you mean? What datatypes
at what position?

@adamwathan https://github.com/adamwathan Are you willing to merge this
pull request? For us these changes are very important, cause the
development time decreases extremly.
Otherwise we use our own forked repository.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#110 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE6y6Q0QrgrftRnINjY2JVnEvcLVqQbrks5qYwH6gaJpZM4JFFmV
.

@adamwathan
Copy link
Owner

Looks like some alignment is messed up on quite a few doc blocks. If that gets cleaned up I'm happy to merge for the greater good (despite my hatred for doc blocks! 😄)

image

@Tjoosten
Copy link

Tjoosten commented Aug 2, 2016

@adamwathan maybe we can fix this with a .editorconfig file in the repo

@coveralls
Copy link

coveralls commented Aug 18, 2016

Coverage Status

Coverage increased (+0.03%) to 90.909% when pulling 864ce75 on bussnet:master into c11c418 on adamwathan:master.

@bussnet
Copy link
Author

bussnet commented Aug 18, 2016

@adamwathan sorry for the messed format, my ide has used tabs before /** and spaces before the following * - stupid. It's now corrected
@Tjoosten good idea with the datatypes, but alot of work.. this was a lot of automatic matching and is for the most cases helpfull enough.

@soham2008xyz
Copy link

@bussnet @adamwathan please have a look at #144, I have fixed the merge conflict with this PR and also added support for Laravel 5.5 package auto-discovery.

Cheers @adamwathan for building this nifty package! 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants