Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- added lastCanBeLowest option, which allows last column to be shorter t... #160

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

- added lastCanBeLowest option, which allows last column to be shorter t... #160

wants to merge 2 commits into from

Conversation

aboritskiy
Copy link

  • allow last column to be shorter than the rest, this relaxes the columnizer algorithm a bit, to allow correct solution, when there are long 'dontsplit' blocks.
  • updated script header to keep that comment while minification with uglify.

- added lastCanBeLowest option, which allows last column to be shorte…
45f4600 
…r than the rest this relaxes the columnizer algorithm a bit, to allow correct solution, when there are long 'dontsplit' blocks.

- updated script header to keep that comment while minification with uglify.
@adamwulf
Copy link
Owner

This looks awesome, thanks! Can you also add a sample.html that tests/shows this feature in action?

@aboritskiy
Copy link
Author

Sorry for late reply.
Also added allowLongDontSplit option, which helps handling dontsplit blocks which are higher then expected column high, this fix actualy much more efficient than original one,
Added to samples a nice example to show the usecase of allowLongDontSplit option.

- fixed errors of previous commit
f009d18 
- added allowLongDontSplit option, which helps handling dontsplit blocks which are higher then expected column high.
- added some samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aboritskiy @adamwulf