Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datasets tests for FDS #2964

Merged
merged 23 commits into from
Apr 25, 2024
Merged

Add datasets tests for FDS #2964

merged 23 commits into from
Apr 25, 2024

Conversation

adam-narozniak
Copy link
Member

Issue

Many of the datasets are not tested.

Description

The test would enable checking the integration of the datasets with the FDS library.

Proposal

Mocking datasets to enable the tests of bigger datasets.

Explanation

  • New file mock_utils.py contains 1) the code for mocking specific columns 2) the code for mocking specific datasets
  • Change and extend the federated_datasets_test.py

Changelog entry

@adam-narozniak adam-narozniak self-assigned this Feb 27, 2024
@adam-narozniak adam-narozniak changed the title Fds add datasets tests Add datasets tests for FDS Feb 28, 2024
jafermarq
jafermarq previously approved these changes Mar 11, 2024
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of mock_utils needs to be changed, otherwise the build system will include it in the final release. Only files ending in _test are excluded.

@adam-narozniak
Copy link
Member Author

I changed the name from mock_utils to mock_utils_test

@danieljanes danieljanes enabled auto-merge (squash) April 25, 2024 12:05
@danieljanes danieljanes merged commit f50f690 into main Apr 25, 2024
33 checks passed
@danieljanes danieljanes deleted the fds-add-tests branch April 25, 2024 13:01
mohammadnaseri pushed a commit that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants