Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(framework) Make argparse processing the first action of SuperNode and SuperLink #4332

Merged
merged 4 commits into from
Oct 13, 2024
Merged

refactor(framework) Make argparse processing the first action of SuperNode and SuperLink #4332

merged 4 commits into from
Oct 13, 2024

Conversation

jafermarq
Copy link
Contributor

@jafermarq jafermarq commented Oct 12, 2024 •
edited
Loading

  • Updates the help message associated to --flwr-dir
  • Moves the "Start SuperNode/Superlink" logs after the argparse has been processed (so they do not appear if a user does flower-supernode --help or flower-superlink --help.

@jafermarq jafermarq changed the title refactor(framework) Adjust argparse help message in SuperNode refactor(framework) Make argparse processing the first action of SuperNode and SuperLink Oct 12, 2024
@jafermarq jafermarq marked this pull request as ready for review October 12, 2024 17:18
panh99
panh99 previously approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

danieljanes
danieljanes previously approved these changes Oct 13, 2024
View reviewed changes
@danieljanes danieljanes enabled auto-merge (squash) October 13, 2024 18:57
@danieljanes danieljanes merged commit c3cc7d9 into main Oct 13, 2024
53 checks passed
@danieljanes danieljanes deleted the adjust-supernode-argparse-help branch October 13, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@panh99 panh99 panh99 left review comments

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jafermarq @danieljanes @panh99