Enable throwSuggestions RTL configuration
#3367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstepien
reviewed
Oct 17, 2023
| @@ -1,4 +1,7 @@ | |||
| import { act } from 'react-dom/test-utils'; | |||
| import { configure } from '@testing-library/react'; | |||
|
|
|||
| configure({ throwSuggestions: true }); | |||
There was a problem hiding this comment.
Duration 67.79s (transform 1.28s, setup 7.69s, collect 7.75s, tests 29.41s, environment 12.71s, prepare 2.69s)
The tests take over 1 minute now, I think it's fine to try it from time to time to improve tests, but I'm 👎 on keeping this enabled.
There was a problem hiding this comment.
How long does it take without this change?
There was a problem hiding this comment.
NVM I thought the GH CI was faster than that
| @@ -16,25 +16,25 @@ describe('Editor', () => { | |||
| it('should open editor on double click', async () => { | |||
| render(<EditorTest />); | |||
| await userEvent.click(getCellsAtRowIndex(0)[0]); | |||
| expect(screen.queryByLabelText('col1-editor')).not.toBeInTheDocument(); | |||
| expect(screen.queryByRole('spinbutton', { name: 'col1-editor' })).not.toBeInTheDocument(); | |||
There was a problem hiding this comment.
What element are we actually querying here? I don't really understand what a spinbutton is
There was a problem hiding this comment.
input type=number.
amanmahajan7
commented
Oct 17, 2023
nstepien
reviewed
Oct 17, 2023
test/sorting.test.tsx
Outdated
| ); | ||
| expect( | ||
| JSON.parse(screen.getByTestId('sortColumnsValue', { suggest: false }).textContent!) | ||
| ).toStrictEqual(expectedValue); |
There was a problem hiding this comment.
Can we use toHaveTextContent?
This reverts commit f051f4d.
nstepien
approved these changes
Oct 17, 2023
adityatoshniwal
pushed a commit
to pgadmin-org/react-data-grid
that referenced
this pull request
Jul 31, 2024
* Enable `throwSuggestions` * Fix tests * Fix sorting tests * Update test/setup.ts * Revert "Update test/setup.ts" This reverts commit f051f4d. * Use `toHaveTextContent`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://testing-library.com/docs/dom-testing-library/api-configuration/#throwsuggestions-experimental