Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data-cy prop #3643

Merged
merged 8 commits into from
Jan 7, 2025
Merged

Add data-cy prop #3643

merged 8 commits into from
Jan 7, 2025

Conversation

amanmahajan7
Copy link
Contributor

@amanmahajan7 amanmahajan7 commented Nov 22, 2024

Looks like this can be useful. I tried to allow any data-attributes but that can be error prone as spreading props in general is not safe

@amanmahajan7 amanmahajan7 self-assigned this Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (071dd8f) to head (848ac91).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3643      +/-   ##
==========================================
- Coverage   93.08%   90.17%   -2.92%     
==========================================
  Files          48       48              
  Lines        3457     3459       +2     
  Branches      684      660      -24     
==========================================
- Hits         3218     3119      -99     
- Misses        239      340     +101     
Files with missing lines Coverage Δ
src/DataGrid.tsx 84.74% <100.00%> (-4.01%) ⬇️

... and 11 files with indirect coverage changes

@amanmahajan7 amanmahajan7 changed the title Add support for specifying data attributes <del>Add support for specifying data attributes</del> Nov 22, 2024
@amanmahajan7 amanmahajan7 changed the title <del>Add support for specifying data attributes</del> Add data-cy prop Nov 22, 2024
@amanmahajan7 amanmahajan7 marked this pull request as ready for review November 22, 2024 22:06
Copy link
Contributor

@nstepien nstepien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for cypress?

@amanmahajan7
Copy link
Contributor Author

Is this for cypress?

yeah

@amanmahajan7 amanmahajan7 merged commit fc63ace into main Jan 7, 2025
3 checks passed
@amanmahajan7 amanmahajan7 deleted the am-data-attributes branch January 7, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants