Tests #309
Closed
Tests #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test version of Bessel beams implementation in ADDA
Add files via upload
Added other BB types (trial version).
Redefined a parallel polarization of BB taking into account its additional phase.
- disables all code related to Bessel beams when NO_FORTRAN is used - edits a lot of help and information messages, including names of some Bessel beams types - beam center in laboratory reference frame is now specified always (even when at origin) - calculation of Cext through F(0) is now used only for default position of the plane wave - fixes processing of imaginary part of matrix M (for Bessel beams), by changing the type to doublecomplex - removes beam-center position in descriptive strings for beams (since it is printed separately in param.c) - plane wave in surface mode now works fine with -beam_center. Removes a lot of redundant code there (probably was used long ago for alternative calculation of Cext) minor/stylistic changes: - shortens define handles for Bessel beams - changes required number of subarguments for '-beam dipole' to UNDEF - moves beam_center below beam in lists of command line options (to be in alphabetical order) - renames use_beam_center and use_beam_subopt into beam_center_used and deprecated_bc_used, respectively - adds auxiliary function ScanDouble3Error() in param.c - removes redundant checks for number of arguments for most Bessel beam types - processing of deprecated specification of beam center as an argument to '-beam' is now in param.c - updates instructions for adding new beams - updates .gitignore - removes mentioning of eIncRefl[3],eIncTran[3] from crosssec.c - beam_center_0 is now defined in vars.c/h
…sel beams - corrects accounting for beam vorticity, when computing amplitude matrix (for scat_plane and scat_grid) - renames variables for Bessel beams to avoid confusion - slightly changes alignment in the code and descriptive string for Bessel beams - merges two cases for Bessel beams in InitBeam() into one - replaces several cexp(I*...) by imExp(...) - adds several TODO comments for further improvement - quick tests show that amplitude matrix remains invariant under 90-degree rotation for symmetric shapes (comparing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed comp2exec for the newest ADDA version with beam center and Bessel beams.
Related issues
Fixes #209, including #285.
Fixes #... or Related to #...
Types of changes
Checklist
make seq)NO_FORTRANorNO_CPPpreprocessor macros, respectively.README.mdin corresponding folders.make seq OPTIONS=DEBUG, but betterdevtools/build_debug) or they are discussed belowsh comp2exec seqintests/2exec, but betterdevtools/test_new [seq]). If any errors appear, they are discussed below.tests/2exec(and potentially new ignore patterns). In some cases, it is desirable to add new tests totests/equiv.git diffor, better, some GUI tool, to ensure that no unexpected changes are introduced.