Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in tests #310

Merged
merged 4 commits into from
Jan 7, 2022
Merged

Changes in tests #310

merged 4 commits into from
Jan 7, 2022

Conversation

stefaniagl
Copy link
Contributor

@stefaniagl stefaniagl commented Dec 30, 2021 •
edited by myurkin
Loading

Description

Changed comp2exec for the newest ADDA version with beam center and Bessel beams.

Related issues

Related to #209, #285.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the contributing guidelines
  • The new code complies with the existing code style.
  • The code compiles correctly in all relevant regimes (at least, make seq)
  • The new code does not rely on any Fortran or C++ sources or is disabled by NO_FORTRAN or NO_CPP preprocessor macros, respectively.
  • The change neither adds or removes files; otherwise, these changes are reflected in README.md in corresponding folders.
  • No warnings appear during debug compilation (at least, make seq OPTIONS=DEBUG, but better devtools/build_debug) or they are discussed below
  • Tests pass locally with my changes (at least, sh comp2exec seq in tests/2exec, but better devtools/test_new [seq]). If any errors appear, they are discussed below.
  • I have added tests that prove my fix is effective or that my feature works. And these tests pass. This includes new command line in suite files in tests/2exec (and potentially new ignore patterns). In some cases, it is desirable to add new tests to tests/equiv.
  • I have added/extended necessary documentation (if appropriate). If suggesting changes to the manual, I have used "Track changes" in the doc file.
  • I have looked through all changes introduced by this pull request (line by line), using git diff or, better, some GUI tool, to ensure that no unexpected changes are introduced.

@myurkin myurkin linked an issue Dec 30, 2021 that may be closed by this pull request
new cmdline argument "-beam_center" #285
Open
@myurkin myurkin removed a link to an issue Dec 30, 2021
new cmdline argument "-beam_center" #285
Open
@myurkin myurkin self-assigned this Dec 30, 2021
@myurkin myurkin added this to the 1.5 milestone Dec 30, 2021
@myurkin myurkin self-requested a review December 30, 2021 08:35
@myurkin
Corrections in GenerateB.c:
675e6ad 
- removes redundant EOL in multi-line beam descriptions
- fixes incorrect calculation of incident plane wave for grazing incidence in surface mode (when prop_z is on the order of 1e-16). For that the code was completely rewritten to specifically calculate potentially small quantities (e.g., expm1 instead of exp and rcp1=rc+1 instead of rc). Small tests indicate that
- removes duplicate initialization of `prIncRefl`
- mentions `vorticity` in instructions for adding new beam
- in several places (when accounting for `beam_center`) `LinComb()` was replaced by `vSubtr()`.

Other changes:
- updates ignores in `comp2exec` so that all tests pass
- fixes a typo in `suite_sparse`
- adds functions `imExpM1()` and `cExpM1()` to `cmplx.h`
- definitions of `prIncRelf` and `prIncTran` are now semi-global (only in `GenerateB.c` and `param.c`)
- updates copyright year in `param.c`
@myurkin myurkin merged commit deebdbf into adda-team:master Jan 7, 2022
stefaniagl added a commit to stefaniagl/adda that referenced this pull request Mar 29, 2022
@stefaniagl
Squashed commit of the following:
753f790 
commit 443f00a
Author: Maxim Yurkin <[email protected]>
Date:   Tue Mar 29 13:34:30 2022 +0700

    Minor changes in figure spacing

commit 581bec6
Author: stefaniagl <[email protected]>
Date:   Tue Mar 29 00:03:24 2022 +0700

    Bessel 0 (adda-team#315)

    Tests and examples for Bessel beams:
    - test using equivalent command line strings `tests/equiv/bb_equiv.py`
    - simple examples `examples/bessel`
    - scripts to reproduce 4 figures in a recent paper (submitted)

    Fixes a bug in TML type of Bessel beams.

commit d7e6169
Author: Maxim Yurkin <[email protected]>
Date:   Mon Feb 21 23:35:49 2022 +0700

    Makes the test for inconsistencies in the input shape format more sensitive. Detects extra number present in a line for ADDA formats (both single- and multi-domain). The formats themselves are now defines instead of static strings.

commit 887a63c
Author: Maxim Yurkin <[email protected]>
Date:   Mon Feb 21 14:48:46 2022 +0700

    - All math constants are now given to 35 significant digits (was 32 in most places)
    - This includes the LDR constants (for which a separate calculation procedure was performed)
    - Improves a few related comments

commit a993a91
Author: Maxim Yurkin <[email protected]>
Date:   Tue Feb 15 10:21:53 2022 +0700

    - renames find_adda.sh into find_adda (and sets executable flag)
    - this script now returns ADDA path to stdout, hence does not need to be sourced (was a bad idea due to potential variables collision)
    - updates all calling scripts

commit c8ea4ed
Author: Maxim Yurkin <[email protected]>
Date:   Mon Jan 31 14:52:02 2022 +0700

    minor formatting changes

commit a6be5f4
Author: Maxim Yurkin <[email protected]>
Date:   Mon Jan 31 14:31:10 2022 +0700

    - adds a special script to locate ADDA binaries (to be used by various examples).
    - updates existing examples in `examples/papers/2021_WKBr/` and `misc/near_field/` accordingly
    - other minor changes to `examples/papers/2021_WKBr/calc.sh`

commit 2896575
Author: inzhevatkin <[email protected]>
Date:   Sun Jan 30 11:40:56 2022 +0700

    WKBr scripts (adda-team#311)

    * Adds scripts to reproduce Figs.15 and 16 from paper (Inzhevatkin & Yurkin, 2022)
    * Includes general-purpose scripts to generate internal field in a sphere in the framework of the WKBr approximation (two modifications).
    * Also includes interface with Mie-theory calculations.

    Co-authored-by: Maxim Yurkin <[email protected]>

commit 6c0b401
Merge: 49e6c23 deebdbf
Author: Maxim Yurkin <[email protected]>
Date:   Tue Jan 11 19:11:38 2022 +0700

    Merge branch 'master' of github.com:adda-team/adda

commit 49e6c23
Author: Maxim Yurkin <[email protected]>
Date:   Tue Jan 11 19:09:51 2022 +0700

    Updates extracting of gcc version in Makefile to be compatible with all possible configurations of gcc.

commit deebdbf
Author: stefaniagl <[email protected]>
Date:   Fri Jan 7 17:44:39 2022 +0700

    Changes in tests (adda-team#310)

    - updates ignores in `comp2exec` so that all tests pass (after recent adda-team#304)
    - adds -beam_center to various lines in test suites

    * Corrections in `GenerateB.c`:
    - removes redundant EOL in multi-line beam descriptions
    - fixes incorrect calculation of incident plane wave for grazing incidence in surface mode (when prop_z is on the order of 1e-16). For that the code was completely rewritten to specifically calculate potentially small quantities (e.g., expm1 instead of exp and rcp1=rc+1 instead of rc).
    - removes duplicate initialization of `prIncRefl`
    - mentions `vorticity` in instructions for adding new beam
    - in several places (when accounting for `beam_center`) `LinComb()` was replaced by `vSubtr()`.

    * Other changes:
    - adds functions `imExpM1()` and `cExpM1()` to `cmplx.h`
    - definitions of `prIncRelf` and `prIncTran` are now semi-global (only in `GenerateB.c` and `param.c`)
    - updates copyright year in `param.c`

    Co-authored-by: Maxim Yurkin <[email protected]>

commit 6a9ec2e
Author: Maxim Yurkin <[email protected]>
Date:   Mon Jan 3 00:02:33 2022 +0700

    adds ignoring of errors when getting commit hash (i.e. when compiling from downloaded source code, not from git repository)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myurkin myurkin myurkin approved these changes

Assignees

@myurkin myurkin

Labels
None yet
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@stefaniagl @myurkin