[Multi-surface mode] #312
Draft
[Multi-surface mode] #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial commit
myurkin
reviewed
Jan 17, 2022
minor improvements and fixes
fixed a comment
# Conflicts: # src/GenerateB.c # src/crosssec.c # src/interaction.c # src/vars.c # src/vars.h
further merge fix
…ach new layer adds three arguments to the end. Also a number of minor textual changes.
myurkin
reviewed
Feb 14, 2022
There was a problem hiding this comment.
I have added one more comment (related to the existing one) and have just pushed a few corrections. The latter also replaces spaces with tabs in indents in some places (where I noticed).
But please check all your code additions for that (this may require changing the settings in your IDE). Also, please do not use space after commas in function arguments
| if (ReflRelation==(enum refl)UNDEF) ReflRelation = msubInf ? GR_IMG : GR_SOM; | ||
| else if (msubInf && ReflRelation!=GR_IMG) PrintError("For perfectly reflecting surface interaction is always " | ||
| if (ReflRelation==(enum refl)UNDEF) ReflRelation = sub.mInf ? GR_IMG : GR_SOM; | ||
| else if (sub.mInf && ReflRelation!=GR_IMG) PrintError("For perfectly reflecting surface interaction is always " |
There was a problem hiding this comment.
When you change this one, the help string for -int_surf should also be updated.
Added a function to calculate fresnel coefficients in the case of two-layer substrate. Added corresponding corrections for plane beam generation.
The procedure of generalized fresnel coefficients calculation in crossec.c is changed. Added minor code improvements and comments.
In SubstrateFresnel function "restrict" keyword is replaced with "const" for destination pointers: NULL could be passed multiple times to the function and cause UB.
Generalized Fresnel coefficients were redefined and supplied with libcheck unit tests. Added initial files for creation of python wrappers of ADDA functions
Tested the calculation of the incidence field and scattered field in the case of a multi-layer substrate.
added full support for calculations with a two-layer substrate by the image method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi surface mode (work in progress)