Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed id from row to column in multiple Scenario #498

Merged
merged 6 commits into from
Nov 22, 2023

Conversation

sMeilbeck
Copy link
Collaborator

Die add_new_row id wurde doppelt vergeben, hiermit möchte ich dies berichtigen

@sMeilbeck sMeilbeck changed the title Changed id from row to coulmn in multiple Scenario Changed id from row to columnin multiple Scenario Nov 16, 2023
@sMeilbeck sMeilbeck changed the title Changed id from row to columnin multiple Scenario Changed id from row to column in multiple Scenario Nov 16, 2023
@nkarmazina
Copy link
Collaborator

Alles sieht ziemlich gut aus. Mir ist nur eine Sache aufgefallen, dass die Buttuns IDs inputExample_rename und inputExample_delete heißen, obwohl es keine direkte Beziehung zu Input elemente gibt. Wahrscheinlich wäre es besser, wenn sie beispielsweise rename_example, delete_example heißen würden.
Ansonsten der Brunch ist mergeable!

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sMeilbeck sMeilbeck merged commit fa82e2c into dev Nov 22, 2023
3 checks passed
@sMeilbeck sMeilbeck deleted the MultipleScenario-IDChange-RowToColumn branch November 22, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants