Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builtin grammar types #17

Merged
merged 16 commits into from
Sep 30, 2013
Merged

Builtin grammar types #17

merged 16 commits into from
Sep 30, 2013

Conversation

benlangfeld
Copy link
Member

WIP

@benlangfeld
Copy link
Member Author

Tagging interested parties @bklang, @vindir, @sfgeorge.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.12%) when pulling dc9614f on feature/builtin_grammars into 580756a on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.14%) when pulling 8e3a3e9 on feature/builtin_grammars into 580756a on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.14%) when pulling 70b8530 on feature/builtin_grammars into 580756a on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-69.68%) when pulling 70b8530 on feature/builtin_grammars into 580756a on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.14%) when pulling 7d8af86 on feature/builtin_grammars into 580756a on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.14%) when pulling febbc41 on feature/builtin_grammars into 580756a on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.14%) when pulling 0b0d947 on feature/builtin_grammars into 580756a on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.14%) when pulling 0b0d947 on feature/builtin_grammars into 580756a on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.15%) when pulling 3a9bb29 on feature/builtin_grammars into 580756a on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.15%) when pulling a6e7af5 on feature/builtin_grammars into 580756a on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.63%) when pulling e4eb707 on feature/builtin_grammars into 580756a on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.59%) when pulling ff6265d on feature/builtin_grammars into 580756a on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.54%) when pulling ea6ef22 on feature/builtin_grammars into 580756a on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.55%) when pulling 5b8e584 on feature/builtin_grammars into 580756a on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.55%) when pulling 83b50e4 on feature/builtin_grammars into 580756a on develop.

@benlangfeld
Copy link
Member Author

New issues opened for interpretation and HTTP grammar fetching.

@benlangfeld
Copy link
Member Author

I'm going to call this done unless anyone objects to any of the recognition examples. @bklang, @sfgeorge?

@sfgeorge
Copy link
Member

The builtin example for currency looks fine. Does that satisfy the particular currency requirements for my application, or that more for other use cases?

Separate question... I know C/Java XML differences were an issue previously. Any known interpreter differences pcre and java.util.regex? Just wondering.

@benlangfeld
Copy link
Member Author

Stephen, the currency grammar covers examples from your application, plus a few extras, and is in line with the VXML suggestions as far as I can tell.

There should be no differences in results returned on C or Java, and the tests in Ruby are executed on both by CI to make sure of that. If anyone finds a difference, it's a bug :)

@sfgeorge
Copy link
Member

There should be no differences in results returned on C or Java, and the tests in Ruby are executed on both by CI to make sure of that.

Awesome 👍 This looks great in my book. Huge chunk of work. Ben, thanks so much for this!

@benlangfeld benlangfeld merged commit 83b50e4 into develop Sep 30, 2013
@benlangfeld benlangfeld deleted the feature/builtin_grammars branch September 30, 2013 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants