Voicemail messages shouldn't save on timeout. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if a caller reaches the recording_menu and times out, the save_recording method is fired once /per/ loop. This results in duplicate voicemails being saved until the call is hungup or it fails after the third retry. A frequent cause of this condition, at least in wireless, is accidental pocket dialing.
emcgee
changed the title
|
Any chance you can add a spec to show that the call to save the recording is only called once? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a caller reaches the
recording_menuand then times out, thesave_recordingmethod is fired once per loop.This both defeats the purpose of giving them a timeout - since the voicemail is now saved anyway! - and results in duplicate voicemails being saved until the call is hungup or it fails after the third retry (at which point, a fourth voicemail is saved from
failure).A frequent cause of this condition, at least in wireless, is accidental pocket dialing.