Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: Adding new options to the progressbar #98

Merged
merged 7 commits into from
Mar 28, 2024

Conversation

dimtrovich
Copy link
Contributor

  • Ability to change label location: previously, the label was always placed at the bottom of the progressbar. This pull request lets dev choose where to place it
  • Possibility of hiding the progress percentage: originally, I'd designed it to be used internally by the spinner (since we didn't need it in the spinner), but given that the spinner is a complex subject (see Feat add spinner to output #89) perhaps we could come back to it. Nevertheless, I think it could be useful in a classic case, which is why I've kept it.

@dimtrovich dimtrovich changed the title Adding new options to the progressbar patch: Adding new options to the progressbar Mar 26, 2024
remove unecessary comment and fix code-stle
@adhocore adhocore merged commit 4102c8e into adhocore:main Mar 28, 2024
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants