Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cover): Fix linkFullImages 404 not found #1566

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MortalHappiness
Copy link

@MortalHappiness MortalHappiness commented Aug 6, 2024

What does this PR change? What problem does it solve?

See the description in the corresponding issue for details.

This PR changes (path.Join .RelPermalink .Params.cover.image) to (.Params.cover.image) solves the problem. However, I don't know the original context of why .RelPermalink is needed. Please tell me if there are any better ways to solve this problem. Thanks for the reviewers.

Was the change discussed in an issue or in the Discussions before?

Resolves: #1565

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

Copy link

sonarqubecloud bot commented Aug 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] linkFullImages 404 not found
1 participant