Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed logic for the ellipsis #1106

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

bzavhorodskyi
Copy link
Collaborator

@bzavhorodskyi bzavhorodskyi commented Oct 3, 2024

Previously we changed hit directly to add ellipsis, but this adds some "blinking" effect when we switch pages for the search results(with search query). I`ve removed the previous logic and added an ellipsis through a pseudo-elements

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 0:50am

Copy link
Collaborator

@Sporiff Sporiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzavhorodskyi LGTM 👍

@bzavhorodskyi bzavhorodskyi merged commit dc8d18a into main Oct 4, 2024
7 checks passed
@bzavhorodskyi bzavhorodskyi deleted the fix/Fix-for-the-blinks-on-the-search-pagination branch October 4, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants