Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for pg16 test #49

Merged
merged 4 commits into from
Jun 17, 2024
Merged

fix for pg16 test #49

merged 4 commits into from
Jun 17, 2024

Conversation

PerikAdjust
Copy link
Contributor

Some changes for pg16. It works localy but not with docker test. Still work on this, I want to see how workflow with github react.

@PerikAdjust PerikAdjust requested a review from a team April 23, 2024 14:10
za-arthur
za-arthur reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@za-arthur za-arthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I left couple of comments below.

src/parser.c Outdated Show resolved Hide resolved
src/parser.c Outdated Show resolved Hide resolved
za-arthur
za-arthur reviewed May 21, 2024
View reviewed changes
src/parser.c Outdated Show resolved Hide resolved
@PerikAdjust
Copy link
Contributor Author

Thanks for your help @za-arthur ! I can merge it?

@za-arthur
Copy link
Contributor

Thanks for your help @za-arthur ! I can merge it?

Yes, looks good to me. Thank you.

@PerikAdjust PerikAdjust merged commit c73ab18 into master Jun 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@za-arthur za-arthur za-arthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PerikAdjust @za-arthur