Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/utils/postgres.h: define commit interval in metadata #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alip
Copy link
Contributor

@alip alip commented Apr 5, 2023

Previously we had the commit interval hardcoded to 2000 in postgres producer. It is useful to make this configurable for cases where data resiliency is more important than performance.

This commit introduces no functionality change as long as commit_interval is not specified in schaufel configuration. In this case, the default is unchanged and we commit once every 2000 messages.

Ref: #111

Previously we had the commit interval hardcoded to 2000 in postgres
producer. It is useful to make this configurable for cases where data
resiliency is more important than performance.

This commit introduces no functionality change as long as
commit_interval is not specified in schaufel configuration. In this
case, the default is unchanged and we commit once every 2000 messages.

Ref: #111
@alip alip added the review label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant