Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hidden show less button when user leaves the section #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kushalv238
Copy link

@kushalv238 kushalv238 commented Oct 22, 2023

Description

The show less button on the repositories page persists even when scrolled up out of the section, which does not look good. The scrolling down was working properly wherein if someone scrolled down out of the section the button stuck to the end of the relative section. I used the same logic to apply the same for the top part of the section.

Related Issue

Fixes #51

Motivation and Context

The button staying there was really confusing and if clicked even when out of the section you will be dragged down to the start of the section.

How Has This Been Tested?

This was a minor bug change so simple manual testing was enough wherein I checked the button's working and hiding for every screen width and in every scenario.

Screenshots (if appropriate):

2023-10-22.20-02-20.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Less button overlaps and flies in the middle of the screen blocking content
1 participant