#2872 update AEM mocks #2874
Open
#2872 update AEM mocks #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2874 +/- ##
============================================
+ Coverage 87.15% 87.17% +0.01%
- Complexity 2692 2694 +2
============================================
Files 235 235
Lines 7188 7191 +3
Branches 1100 1101 +1
============================================
+ Hits 6265 6269 +4
Misses 365 365
+ Partials 558 557 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the AEM Mocks to the latest version; due to changes in https://wcm.io/testing/aem-mock/changes-report.html#a5.5.4 I had to adjust a few locations which are using the Externalizer.
To reduce the effort, I have decided to adjust
LinkBuilder.buildLinkso it will do aResourceResolver.map()call to calculate theurlparameter for the Link. Which is not a problem per see, as it would still meet the constraints of the API. But it's no longer identical to the repository path.(Doing it differently would require a major overhaul of the test suite of the inner working of
LinkBuilderImplandLinkImpl.)