Added a new feature to toggle between technical names and display names in the XDM Object #446

shammowla · 2024-11-22T17:11:43Z

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Improvement (non-breaking change which does not add functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA or I'm an Adobe employee.
I have made any necessary test changes and all tests pass.
I have run the Sandbox successfully.
I've updated the schema in extension.json or no changes are necessary.
My change requires a change to the documentation.

carterworks · 2024-11-22T18:09:28Z

There are 7 failing tests, all around update variable. On other PRs, 5 are failing, meaning 2 are unique to your changes. Here are the tests that are newly failing.

× Update variable action view - keeps data around when changing data elements and schema objects

      1) The specified selector does not match any element in the DOM tree.
  > | Selector('[data-test-id='xdmTree']')
  | .find('[data-test-id='xdmTreeNodeTitleDisplayName']')
  | .withText('otherField')
  | .parent('[data-test-id='xdmTreeNodeTitle']')
  | .nth(0)

  Browser: Chrome 129.0.0.0 / Windows 11

  50 | .parent(".ant-tree-treenode")
  51 | .nth(0)
  52 | .find(".ant-tree-switcher");
  53 | return {
  54 | click: async () => {
  > 55 | await t.click(node);
  56 | },
  57 | toggleExpansion: async () => {
  58 | await t.click(expansionToggle);
  59 | // wait for animation to finish
  60 | await t.wait(100);

  at Object.&lt;anonymous&gt;
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:55:17)
  at asyncGeneratorStep
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:68)
  at _next
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:317)
  at &lt;anonymous&gt;
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:448)
  at Object.&lt;anonymous&gt;
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:247)
  at Object.click [as click]
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:56:47)
  at &lt;anonymous&gt;
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/actions/updateVariable.spec.mjs:235:40)
  at asyncGeneratorStep
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/actions/updateVariable.spec.mjs:1:68)
  at _next
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/actions/updateVariable.spec.mjs:1:317)
  </pre>
</details>

× Update variable action view - keeps data around when changing data elements and schema arrays

      1) The specified selector does not match any element in the DOM tree.
  > | Selector('[data-test-id='xdmTree']')
  | .find('[data-test-id='xdmTreeNodeTitleDisplayName']')
  | .withText('Item 1')
  | .parent('[data-test-id='xdmTreeNodeTitle']')
  | .nth(0)
  | .parent('.ant-tree-treenode')
  | .nth(0)
  | .find('.ant-tree-switcher')

  Browser: Chrome 129.0.0.0 / Windows 11

  53 | return {
  54 | click: async () => {
  55 | await t.click(node);
  56 | },
  57 | toggleExpansion: async () => {
  > 58 | await t.click(expansionToggle);
  59 | // wait for animation to finish
  60 | await t.wait(100);
  61 | },
  62 | expectInViewport: async () => {
  63 | const isElementInViewport = await getIsElementInViewport(node);

  at Object.&lt;anonymous&gt;
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:58:17)
  at asyncGeneratorStep
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:68)
  at _next
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:317)
  at &lt;anonymous&gt;
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:448)
  at Object.&lt;anonymous&gt;
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:247)
  at Object.toggleExpansion [as toggleExpansion]
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:61:58)
  at &lt;anonymous&gt;
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/actions/updateVariable.spec.mjs:268:36)
  at asyncGeneratorStep
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/actions/updateVariable.spec.mjs:1:68)
  at _next
  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/actions/updateVariable.spec.mjs:1:317)
  </pre>
</details>

jonsnyder

The code looks good. Let's do another demo in standup.

test/functional/helpers/objectEditor/xdmTree.mjs

carterworks

Resolve the two new failing tests and we are golden.

× XDM Object Display Names - toggles between display names and field IDs

1) AssertionError: expected undefined to be truthy
  Browser: Chrome 129.0.0.0 / Windows 11
      30 |  await schemaField.selectMenuOption("XDM Object Data Element Tests");
      31 |  await xdmTree.node("_unifiedjsqeonly").toggleExpansion();
      32 |  await xdmTree.node("vendor").toggleExpansion();
      33 |
      34 |  // Initially should show field IDs (default)
    > 35 |  await t.expect(xdmTree.node("name").exists).ok();
      36 |
      37 |  // Toggle to show display names
      38 |  await xdmTree.enableDisplayNames();
      39 |  await t.expect(xdmTree.node("Name").exists).ok();
      40 |
      at  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/dataElements/xdmObjectDisplayNames.spec.mjs:35:47)
      at asyncGeneratorStep (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/dataElements/xdmObjectDisplayNames.spec.mjs:1:68)
      at _next (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/dataElements/xdmObjectDisplayNames.spec.mjs:1:317)

× XDM Object Editing - allows user to provide individual array items

1) The specified selector does not match any element in the DOM tree.
    > | Selector('[data-test-id='xdmTree']')
      |   .find('[data-test-id='xdmTreeNodeTitleDisplayName']')
      |   .withText(/^implementationDetails$|^implementationdetails$/i)
      |   .parent('[data-test-id='xdmTreeNodeTitle']')
      |   .nth(0)
      |   .parent('.ant-tree-treenode')
      |   .nth(0)
      |   .find('.ant-tree-switcher')
  Browser: Chrome 129.0.0.0 / Windows 11
      54 |  return {
      55 |    click: async () => {
      56 |      await t.click(node);
      57 |    },
      58 |    toggleExpansion: async () => {
    > 59 |      await t.click(expansionToggle);
      60 |      // wait for animation to finish
      61 |      await t.wait(100);
      62 |    },
      63 |    expectInViewport: async () => {
      64 |      const isElementInViewport = await getIsElementInViewport(node);
      at Object. (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:59:17)
      at asyncGeneratorStep (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:68)
      at _next (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:317)
      at  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:448)
      at Object. (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:247)
      at Object.toggleExpansion [as toggleExpansion] (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:62:58)
      at  (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/dataElements/xdmObjectEditing.spec.mjs:37:49)
      at asyncGeneratorStep (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/dataElements/xdmObjectEditing.spec.mjs:1:68)
      at _next (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/dataElements/xdmObjectEditing.spec.mjs:1:317)

shammowla · 2024-12-03T18:37:43Z

There are 7 failing tests, all around update variable. On other PRs, 5 are failing, meaning 2 are unique to your changes. Here are the tests that are newly failing.

* × Update variable action view - keeps data around when changing data elements and schema objects
        
              1) The specified selector does not match any element in the DOM tree.
  ```
    > | Selector('[data-test-id='xdmTree']')
    | .find('[data-test-id='xdmTreeNodeTitleDisplayName']')
    | .withText('otherField')
    | .parent('[data-test-id='xdmTreeNodeTitle']')
    | .nth(0)
  
    Browser: Chrome 129.0.0.0 / Windows 11
  
    50 | .parent(".ant-tree-treenode")
    51 | .nth(0)
    52 | .find(".ant-tree-switcher");
    53 | return {
    54 | click: async () => {
    > 55 | await t.click(node);
    56 | },
    57 | toggleExpansion: async () => {
    58 | await t.click(expansionToggle);
    59 | // wait for animation to finish
    60 | await t.wait(100);
  
    at Object.&lt;anonymous&gt;
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:55:17)
    at asyncGeneratorStep
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:68)
    at _next
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:317)
    at &lt;anonymous&gt;
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:448)
    at Object.&lt;anonymous&gt;
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:247)
    at Object.click [as click]
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:56:47)
    at &lt;anonymous&gt;
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/actions/updateVariable.spec.mjs:235:40)
    at asyncGeneratorStep
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/actions/updateVariable.spec.mjs:1:68)
    at _next
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/actions/updateVariable.spec.mjs:1:317)
    </pre>
  </details>
  ```

* × Update variable action view - keeps data around when changing data elements and schema arrays
              1) The specified selector does not match any element in the DOM tree.
  ```
    > | Selector('[data-test-id='xdmTree']')
    | .find('[data-test-id='xdmTreeNodeTitleDisplayName']')
    | .withText('Item 1')
    | .parent('[data-test-id='xdmTreeNodeTitle']')
    | .nth(0)
    | .parent('.ant-tree-treenode')
    | .nth(0)
    | .find('.ant-tree-switcher')
  
    Browser: Chrome 129.0.0.0 / Windows 11
  
    53 | return {
    54 | click: async () => {
    55 | await t.click(node);
    56 | },
    57 | toggleExpansion: async () => {
    > 58 | await t.click(expansionToggle);
    59 | // wait for animation to finish
    60 | await t.wait(100);
    61 | },
    62 | expectInViewport: async () => {
    63 | const isElementInViewport = await getIsElementInViewport(node);
  
    at Object.&lt;anonymous&gt;
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:58:17)
    at asyncGeneratorStep
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:68)
    at _next
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:317)
    at &lt;anonymous&gt;
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:448)
    at Object.&lt;anonymous&gt;
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:1:247)
    at Object.toggleExpansion [as toggleExpansion]
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/helpers/objectEditor/xdmTree.mjs:61:58)
    at &lt;anonymous&gt;
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/actions/updateVariable.spec.mjs:268:36)
    at asyncGeneratorStep
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/actions/updateVariable.spec.mjs:1:68)
    at _next
    (file:///D:/sauce-testcafe-runner/3.10.0/bundle/__project__/test/functional/specs/view/actions/updateVariable.spec.mjs:1:317)
    </pre>
  </details>
  ```

Fixed the failing test issue. Can you please try running it again and see if you're seeing any failures.

…es in the XDM Object (#446) * Toggle between technical names and display names in the XDM Object. * Rename display name toggle helper and update test.

shammowla requested review from carterworks and jonsnyder November 22, 2024 17:11

shammowla closed this Dec 3, 2024

shammowla force-pushed the PDCL-12749 branch from 02e1b15 to 74054f8 Compare December 3, 2024 17:02

shammowla reopened this Dec 3, 2024

shammowla added 2 commits December 3, 2024 12:30

Toggle between technical names and display names in the XDM Object.

ee12b1f

Revert test spec changes.

873d42d

jonsnyder approved these changes Dec 3, 2024

View reviewed changes

test/functional/helpers/objectEditor/xdmTree.mjs Outdated Show resolved Hide resolved

carterworks requested changes Dec 3, 2024

View reviewed changes

shammowla added 2 commits December 3, 2024 13:23

Increase concurrent functional test runs.

6e62882

Rename display name toggle helper and update test.

3d604b4

shammowla force-pushed the PDCL-12749 branch from ce28de0 to 3d604b4 Compare December 3, 2024 18:25

carterworks approved these changes Dec 4, 2024

View reviewed changes

Merge branch 'main' into PDCL-12749

208f4bb

shammowla merged commit 96ff4ae into main Jan 10, 2025
4 checks passed

shammowla deleted the PDCL-12749 branch January 10, 2025 17:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a new feature to toggle between technical names and display names in the XDM Object #446

Added a new feature to toggle between technical names and display names in the XDM Object #446

shammowla commented Nov 22, 2024

carterworks commented Nov 22, 2024 •

edited

Loading

jonsnyder left a comment

carterworks left a comment •

edited

Loading

shammowla commented Dec 3, 2024

Added a new feature to toggle between technical names and display names in the XDM Object #446

Added a new feature to toggle between technical names and display names in the XDM Object #446

Conversation

shammowla commented Nov 22, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

Checklist:

carterworks commented Nov 22, 2024 • edited Loading

jonsnyder left a comment

Choose a reason for hiding this comment

carterworks left a comment • edited Loading

Choose a reason for hiding this comment

shammowla commented Dec 3, 2024

carterworks commented Nov 22, 2024 •

edited

Loading

carterworks left a comment •

edited

Loading