Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(popover): keep nested drop shadows from affecting the other #1909

Merged
merged 2 commits into from
May 31, 2023
Merged

fix(popover): keep nested drop shadows from affecting the other #1909

merged 2 commits into from
May 31, 2023

Conversation

mlogsdon18
Copy link
Contributor

Description

This is in response to Issue #1873 where the drop-shadows of nested Popovers affected each other due to the use of the filter property.

This PR adds a filter variable to prevent any nested Popovers from doubling down on the filter.

How and where has this been tested?

  • How this was tested: A Nested story was added to Storybook in order to test nested Popovers

Screenshots

The difference is subtle but you can see that the drop-shadow is much darker in the original as the filter was being layered
Current
Screenshot 2023-05-30 at 3 08 42 PM

Updated
Screenshot 2023-05-30 at 3 08 23 PM

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested these changes in Windows High Contrast mode.
  • I have updated any relevant storybook stories and templates.
  • If my change(s) include visual change(s), a designer has reviewed and approved those changes.
  • This pull request is ready to merge.

@mlogsdon18 mlogsdon18 requested a review from Westbrook May 30, 2023 19:13
@github-actions
Copy link
Contributor

🚀 Deployed on https://pr-1909--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 30, 2023 19:19 Inactive
Westbrook
Westbrook approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label May 30, 2023
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label May 30, 2023
@pfulton pfulton merged commit f5c206d into main May 31, 2023
@pfulton pfulton deleted the css-527-popover-drop-shadow branch May 31, 2023 14:19
venkateshjo pushed a commit that referenced this pull request May 31, 2023
@mlogsdon18 @venkateshjo
fix(popover): keep nested drop shadows from affecting the other (#1909)
ed77dc3 
* chore(popover): add with tip and nested stories
* fix(popover): add styling so nested drop shadows are separate
jawinn pushed a commit that referenced this pull request Jun 1, 2023
@mlogsdon18 @jawinn
fix(popover): keep nested drop shadows from affecting the other (#1909)
7dd56bf 
* chore(popover): add with tip and nested stories
* fix(popover): add styling so nested drop shadows are separate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Westbrook Westbrook Westbrook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlogsdon18 @Westbrook @pfulton