-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(popover): no more duplicate class selectors in dist #2745
Conversation
🦋 Changeset detectedLatest commit: a7b6f94 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Deployed on https://pr-2745--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.42 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailspopover
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh the trouble that a misplaced curly brace can cause 😆 This seems to have fixed it. It's a little tricky to validate with how Storybook currently handles the popover interaction, but I tried all the positioning options + a browser refresh each time and did not see anything unusual for the "with tip" variant.
16b75d7
to
2d4f9d3
Compare
2d4f9d3
to
a7b6f94
Compare
Description
Fix for issue #2705. Previously, there were duplicate class selectors in dist. This update adjusts the selectors to remove the duplicates.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
To-do list