-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove action-button variant property #4741
Merged
rubencarvalho
merged 7 commits into
ruben/remove-deprecations
from
ruben/remove-action-button-deprecations
Oct 16, 2024
Merged
chore: remove action-button variant property #4741
rubencarvalho
merged 7 commits into
ruben/remove-deprecations
from
ruben/remove-action-button-deprecations
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubencarvalho
added
1.0.0
Issues that should be addressed for a 1.0 release!
Breaking
labels
Oct 15, 2024
Rajdeepc
requested changes
Oct 16, 2024
packages/action-button/stories/action-button-white-quiet.stories.ts
Outdated
Show resolved
Hide resolved
packages/action-button/stories/action-button-white-quiet.stories.ts
Outdated
Show resolved
Hide resolved
packages/action-button/stories/action-button-white-quiet.stories.ts
Outdated
Show resolved
Hide resolved
packages/action-button/stories/action-button-white-quiet.stories.ts
Outdated
Show resolved
Hide resolved
packages/action-button/stories/action-button-white-quiet.stories.ts
Outdated
Show resolved
Hide resolved
packages/action-button/stories/action-button-white-quiet.stories.ts
Outdated
Show resolved
Hide resolved
Rajdeepc
approved these changes
Oct 16, 2024
Tachometer resultsChromeaccordion permalinkbasic-test
action-bar permalinkbasic-test
action-button permalinkbasic-test
action-group permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
alert-banner permalinkbasic-test
alert-dialog permalinkbasic-test
asset permalinkbasic-test
avatar permalinktest-basic
badge permalinkbasic-test
breadcrumbs permalinkbasic-test
button-group permalinkbasic-test
button permalinktest-basic
card permalinktest-basic
checkbox permalinktest-basic
coachmark permalinkbasic-test
color-area permalinkbasic-test
color-field permalinkbasic-test
color-handle permalinkbasic-test
color-loupe permalinkbasic-test
color-slider permalinkbasic-test
color-wheel permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
contextual-help permalinkbasic-test
dialog permalinkbasic-test
divider permalinkbasic-test
dropzone permalinktest-basic
field-group permalinkbasic-test
field-label permalinkbasic-test
grid permalinkbasic-test
help-text permalinkbasic-test
icon permalinktest-basic
icons permalinktest-basic
illustrated-message permalinktest-basic
infield-button permalinkbasic-test
link permalinktest-basic
menu permalinktest-basic
meter permalinkbasic-test
number-field permalinkbasic-test
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker-button permalinkbasic-test
picker permalinkbasic-test
popover permalinktest-basic
progress-bar permalinkbasic-test
progress-circle permalinkbasic-test
radio permalinktest-basic
search permalinktest-basic
sidenav permalinktest-basic
slider permalinktest-basic
split-view permalinkbasic-test
swatch permalinkbasic-test
switch permalinktest-basic
table permalinkbasic-test
tabs permalinkbasic-test
tags permalinkbasic-test
textfield permalinktest-basic
thumbnail permalinkbasic-test
toast permalinktest-basic
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
top-nav permalinkbasic-test
tray permalinkbasic-test
truncated permalinkbasic-test
underlay permalinkbasic-test
Firefoxaccordion permalinkbasic-test
action-bar permalinkbasic-test
action-button permalinkbasic-test
action-group permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
alert-banner permalinkbasic-test
alert-dialog permalinkbasic-test
asset permalinkbasic-test
avatar permalinktest-basic
badge permalinkbasic-test
breadcrumbs permalinkbasic-test
button-group permalinkbasic-test
button permalinktest-basic
card permalinktest-basic
checkbox permalinktest-basic
coachmark permalinkbasic-test
color-area permalinkbasic-test
color-field permalinkbasic-test
color-handle permalinkbasic-test
color-loupe permalinkbasic-test
color-slider permalinkbasic-test
color-wheel permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
contextual-help permalinkbasic-test
dialog permalinkbasic-test
divider permalinkbasic-test
dropzone permalinktest-basic
field-group permalinkbasic-test
field-label permalinkbasic-test
grid permalinkbasic-test
help-text permalinkbasic-test
icon permalinktest-basic
icons permalinktest-basic
illustrated-message permalinktest-basic
infield-button permalinkbasic-test
link permalinktest-basic
menu permalinktest-basic
meter permalinkbasic-test
number-field permalinkbasic-test
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker-button permalinkbasic-test
picker permalinkbasic-test
popover permalinktest-basic
progress-bar permalinkbasic-test
progress-circle permalinkbasic-test
radio permalinktest-basic
search permalinktest-basic
sidenav permalinktest-basic
slider permalinktest-basic
split-view permalinkbasic-test
swatch permalinkbasic-test
switch permalinktest-basic
table permalinkbasic-test
tabs permalinkbasic-test
tags permalinkbasic-test
textfield permalinktest-basic
thumbnail permalinkbasic-test
toast permalinktest-basic
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
top-nav permalinkbasic-test
tray permalinkbasic-test
truncated permalinkbasic-test
underlay permalinkbasic-test
|
rubencarvalho
merged commit Oct 16, 2024
768cc17
into
ruben/remove-deprecations
6 of 56 checks passed
rubencarvalho
added a commit
that referenced
this pull request
Oct 29, 2024
* chore: remove 'variant' and 'static' attributes from coach-indicator (#4772) * chore: remove split-button component (#4729) * chore: remove banner component (#4723) * chore: remove deprecated badge values (#4742) * chore: remove sp-quick-actions (#4761) * chore: remove popover's dialog property (#4751) * chore: remove thumbnail deprecated sizes (#4760) * chore: remove progress-circle overBackground property (#4750) * chore: remove deprecated 'static' references (#4818) * chore: remove action-button variant property (#4741) * chore: remove 'theme' attribute from sp-theme (#4765) * feat: add 1.0.0 migration guide (#4776)
rubencarvalho
pushed a commit
that referenced
this pull request
Oct 30, 2024
…4829) - feat(styles): add Spectrum 2 styles - feat(icons-workflow): add support for new Spectrum 2 icons (#4747) - feat(icon): add support for Spectrum 2 icons (#4747) - chore: remove pre-1.0.0 deprecations (#4828) - feat(coach-indicator)!: remove 'variant' and 'static' attributes from coach-indicator (#4772) - feat(split-button)!: remove split-button component (#4729) - feat(banner)!: remove banner component (#4723) - feat(badge)!: remove deprecated badge values (#4742) - feat(quick-actions)!: remove sp-quick-actions (#4761) - feat(popover)!: remove popover's dialog property (#4751) - feat(thumbnail)!: remove thumbnail deprecated sizes (#4760) - feat(progress-circle)!: remove progress-circle overBackground property (#4750) - feat(action-button,action-group,action-menu,button,link,meter,progress-bar): remove deprecated 'static' references (#4818) - feat(action-button)!: remove action-button variant property (#4741) - feat(theme)!: remove 'theme' attribute from sp-theme (#4765) - chore: make the spectrum-two theme fully functional (#4859) - chore: add 1.0.0 migration guide (#4776)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the
sp-action-button
variant
property along with all associated references and dependencies.Related issue(s)
Motivation and context
For the upcoming 1.0.0 release of Spectrum Web Components, we will remove the deprecated components and features.
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.