Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(reactive-controllers): updates lit dependency #4744

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jnjosh
Copy link
Contributor

@jnjosh jnjosh commented Sep 13, 2024

Description

When we updated to support Lit 2 or Lit 3 we left Reactive Controllers behind, only supporting 3. This has created downstream issues in consumers that don't support Lit 3.

How has this been tested?

  • Need some help in how to best test this.

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • [-] I have added tests to cover my changes.
  • [-] All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@jnjosh jnjosh requested a review from a team as a code owner September 13, 2024 18:19
@jnjosh jnjosh changed the title chore(reactive-controllers): updates lit dependency ti include chore(reactive-controllers): updates lit dependency Sep 13, 2024
Copy link

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Copy link

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 225.833 kB 214.474 kB 214.444 kB 🏆
Scripts 55.536 kB 49.563 kB 🏆 49.85 kB
Stylesheet 34.503 kB 30.374 kB 30.153 kB 🏆
Document 6.189 kB 5.44 kB 5.433 kB 🏆
Font 126.808 kB 126.746 kB 126.659 kB 🏆

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10854136003

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.205%

Totals Coverage Status
Change from base Build 10808456663: 0.0%
Covered Lines: 32515
Relevant Lines: 32946

💛 - Coveralls

Copy link

Tachometer results

Chrome

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 431 kB 75.78ms - 77.93ms - faster ✔
6% - 9%
4.91ms - 7.81ms
branch 408 kB 82.24ms - 84.19ms slower ❌
6% - 10%
4.91ms - 7.81ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 501 kB 49.45ms - 50.52ms - faster ✔
3% - 6%
1.60ms - 3.39ms
branch 477 kB 51.76ms - 53.19ms slower ❌
3% - 7%
1.60ms - 3.39ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 552 kB 46.89ms - 51.22ms - unsure 🔍
-13% - +0%
-7.06ms - +0.31ms
branch 529 kB 49.45ms - 55.41ms unsure 🔍
-1% - +15%
-0.31ms - +7.06ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 669 kB 134.73ms - 137.91ms - faster ✔
6% - 9%
9.07ms - 14.11ms
branch 646 kB 145.96ms - 149.87ms slower ❌
7% - 10%
9.07ms - 14.11ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 623 kB 65.21ms - 66.46ms - faster ✔
6% - 9%
4.54ms - 6.47ms
branch 599 kB 70.61ms - 72.07ms slower ❌
7% - 10%
4.54ms - 6.47ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 622 kB 63.98ms - 65.27ms - faster ✔
6% - 9%
4.39ms - 6.56ms
branch 598 kB 69.23ms - 70.97ms slower ❌
7% - 10%
4.39ms - 6.56ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 813 kB 1881.01ms - 1883.43ms - unsure 🔍
+0% - +0%
+0.86ms - +4.63ms
branch 789 kB 1878.03ms - 1880.92ms unsure 🔍
-0% - -0%
-4.63ms - -0.86ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 812 kB 1874.58ms - 1877.28ms - unsure 🔍
-0% - +0%
-3.80ms - +0.11ms
branch 787 kB 1876.36ms - 1879.18ms unsure 🔍
-0% - +0%
-0.11ms - +3.80ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 686 kB 488.40ms - 493.63ms - faster ✔
1% - 2%
3.76ms - 11.34ms
branch 662 kB 495.82ms - 501.30ms slower ❌
1% - 2%
3.76ms - 11.34ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 90.86ms - 92.53ms - faster ✔
4% - 6%
3.64ms - 6.04ms
branch 621 kB 95.68ms - 97.40ms slower ❌
4% - 7%
3.64ms - 6.04ms
-

color-area permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 469 kB 123.01ms - 126.59ms - unsure 🔍
-2% - +1%
-3.14ms - +0.67ms
branch 446 kB 125.40ms - 126.67ms unsure 🔍
-1% - +3%
-0.67ms - +3.14ms
-

color-slider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 471 kB 104.92ms - 105.99ms - faster ✔
2% - 4%
1.75ms - 4.03ms
branch 448 kB 107.34ms - 109.35ms slower ❌
2% - 4%
1.75ms - 4.03ms
-

color-wheel permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 472 kB 101.49ms - 102.62ms - faster ✔
1% - 3%
1.53ms - 3.02ms
branch 449 kB 103.84ms - 104.81ms slower ❌
1% - 3%
1.53ms - 3.02ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 730 kB 36.95ms - 37.58ms - faster ✔
2% - 4%
0.84ms - 1.70ms
branch 705 kB 38.25ms - 38.82ms slower ❌
2% - 5%
0.84ms - 1.70ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 730 kB 388.75ms - 397.02ms - faster ✔
1% - 3%
2.26ms - 12.67ms
branch 706 kB 397.18ms - 403.51ms slower ❌
1% - 3%
2.26ms - 12.67ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 657 kB 50.36ms - 51.58ms - faster ✔
4% - 7%
2.41ms - 3.94ms
branch 632 kB 53.69ms - 54.61ms slower ❌
5% - 8%
2.41ms - 3.94ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 405 kB 20.03ms - 21.02ms - unsure 🔍
-6% - +0%
-1.27ms - +0.05ms
branch 382 kB 20.69ms - 21.57ms unsure 🔍
-0% - +6%
-0.05ms - +1.27ms
-

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 474 kB 38.57ms - 39.19ms - slower ❌
1% - 4%
0.45ms - 1.56ms
branch 431 kB 37.41ms - 38.34ms faster ✔
1% - 4%
0.45ms - 1.56ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 209.06ms - 212.43ms - faster ✔
1% - 4%
2.43ms - 8.71ms
branch 471 kB 213.67ms - 218.96ms slower ❌
1% - 4%
2.43ms - 8.71ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 46.61ms - 47.30ms - faster ✔
3% - 5%
1.42ms - 2.38ms
branch 397 kB 48.52ms - 49.19ms slower ❌
3% - 5%
1.42ms - 2.38ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 539 kB 65.45ms - 69.46ms - faster ✔
7% - 13%
4.93ms - 9.90ms
branch 516 kB 73.41ms - 76.34ms slower ❌
7% - 15%
4.93ms - 9.90ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 711 kB 423.65ms - 426.59ms - faster ✔
1% - 3%
3.36ms - 14.35ms
branch 687 kB 428.68ms - 439.27ms slower ❌
1% - 3%
3.36ms - 14.35ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 791 kB 21.86ms - 23.49ms - faster ✔
5% - 12%
1.25ms - 3.00ms
branch 766 kB 24.48ms - 25.13ms slower ❌
5% - 14%
1.25ms - 3.00ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 780 kB 343.55ms - 347.39ms - faster ✔
2% - 3%
5.81ms - 10.87ms
branch 755 kB 352.16ms - 355.47ms slower ❌
2% - 3%
5.81ms - 10.87ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 577 kB 41.00ms - 41.63ms - faster ✔
6% - 9%
2.87ms - 3.92ms
branch 552 kB 44.29ms - 45.14ms slower ❌
7% - 10%
2.87ms - 3.92ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 536 kB 497.28ms - 506.50ms - faster ✔
1% - 3%
5.68ms - 17.89ms
branch 512 kB 509.67ms - 517.67ms slower ❌
1% - 4%
5.68ms - 17.89ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 396 kB 11.02ms - 11.17ms - faster ✔
3% - 5%
0.30ms - 0.55ms
branch 374 kB 11.42ms - 11.61ms slower ❌
3% - 5%
0.30ms - 0.55ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 422 kB 27.52ms - 28.03ms - faster ✔
2% - 5%
0.68ms - 1.48ms
branch 398 kB 28.55ms - 29.16ms slower ❌
2% - 5%
0.68ms - 1.48ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 35.48ms - 36.88ms - faster ✔
1% - 9%
0.47ms - 3.29ms
branch 398 kB 36.83ms - 39.28ms slower ❌
1% - 9%
0.47ms - 3.29ms
-

sidenav permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 443 kB 154.23ms - 156.74ms - faster ✔
7% - 11%
11.64ms - 18.25ms
branch 420 kB 167.37ms - 173.48ms slower ❌
7% - 12%
11.64ms - 18.25ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 495 kB 75.62ms - 77.21ms - faster ✔
2% - 5%
1.18ms - 3.58ms
branch 471 kB 77.90ms - 79.70ms slower ❌
2% - 5%
1.18ms - 3.58ms
-

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 747 kB 1864.68ms - 1868.66ms - unsure 🔍
-0% - +0%
-2.08ms - +3.98ms
branch 723 kB 1863.43ms - 1868.01ms unsure 🔍
-0% - +0%
-3.98ms - +2.08ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 422 kB 13.24ms - 13.57ms - faster ✔
6% - 9%
0.87ms - 1.35ms
branch 399 kB 14.34ms - 14.69ms slower ❌
6% - 10%
0.87ms - 1.35ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 441 kB 109.57ms - 110.94ms - faster ✔
1% - 2%
0.62ms - 2.68ms
branch 417 kB 111.14ms - 112.67ms slower ❌
1% - 2%
0.62ms - 2.68ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 465 kB 12.11ms - 12.34ms - unsure 🔍
-1% - +1%
-0.13ms - +0.14ms
branch 441 kB 12.14ms - 12.30ms unsure 🔍
-1% - +1%
-0.14ms - +0.13ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 565 kB 34.01ms - 34.58ms - faster ✔
3% - 6%
1.19ms - 2.12ms
branch 542 kB 35.59ms - 36.31ms slower ❌
3% - 6%
1.19ms - 2.12ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 548 kB 22.93ms - 23.61ms - faster ✔
5% - 8%
1.15ms - 2.08ms
branch 525 kB 24.57ms - 25.20ms slower ❌
5% - 9%
1.15ms - 2.08ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 672 kB 51.50ms - 52.39ms - faster ✔
4% - 6%
1.98ms - 3.27ms
branch 647 kB 54.11ms - 55.04ms slower ❌
4% - 6%
1.98ms - 3.27ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 648 kB 41.53ms - 42.43ms - faster ✔
5% - 8%
2.26ms - 3.48ms
branch 623 kB 44.44ms - 45.26ms slower ❌
5% - 8%
2.26ms - 3.48ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 447 kB 37.74ms - 39.44ms - faster ✔
1% - 7%
0.58ms - 2.92ms
branch 423 kB 39.54ms - 41.14ms slower ❌
1% - 8%
0.58ms - 2.92ms
-

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 538 kB 96.57ms - 97.82ms - faster ✔
1% - 2%
0.57ms - 2.14ms
branch 514 kB 98.07ms - 99.04ms slower ❌
1% - 2%
0.57ms - 2.14ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 544 kB 56.79ms - 57.87ms - faster ✔
3% - 6%
1.90ms - 3.42ms
branch 520 kB 59.46ms - 60.52ms slower ❌
3% - 6%
1.90ms - 3.42ms
-
Firefox

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 431 kB 163.81ms - 170.43ms - faster ✔
3% - 9%
6.06ms - 15.30ms
branch 408 kB 174.57ms - 181.03ms slower ❌
4% - 9%
6.06ms - 15.30ms
-

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 501 kB 108.80ms - 115.68ms - faster ✔
1% - 8%
0.53ms - 9.47ms
branch 477 kB 114.38ms - 120.10ms slower ❌
0% - 9%
0.53ms - 9.47ms
-

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 552 kB 112.78ms - 118.66ms - faster ✔
0% - 6%
0.27ms - 7.81ms
branch 529 kB 117.40ms - 122.12ms slower ❌
0% - 7%
0.27ms - 7.81ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 669 kB 273.12ms - 276.80ms - faster ✔
12% - 14%
37.71ms - 43.65ms
branch 646 kB 313.31ms - 317.97ms slower ❌
14% - 16%
37.71ms - 43.65ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 623 kB 132.24ms - 134.48ms - unsure 🔍
-2% - +0%
-2.62ms - +0.22ms
branch 599 kB 133.69ms - 135.43ms unsure 🔍
-0% - +2%
-0.22ms - +2.62ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 622 kB 145.39ms - 151.53ms - slower ❌
5% - 11%
7.55ms - 15.37ms
branch 598 kB 134.58ms - 139.42ms faster ✔
5% - 10%
7.55ms - 15.37ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 813 kB 1910.12ms - 1920.60ms - slower ❌
0% - 1%
7.42ms - 19.06ms
branch 789 kB 1899.59ms - 1904.65ms faster ✔
0% - 1%
7.42ms - 19.06ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 812 kB 1894.57ms - 1899.47ms - unsure 🔍
-0% - +0%
-3.37ms - +3.25ms
branch 787 kB 1894.86ms - 1899.30ms unsure 🔍
-0% - +0%
-3.25ms - +3.37ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 686 kB 775.68ms - 785.88ms - faster ✔
2% - 4%
14.04ms - 35.44ms
branch 662 kB 796.11ms - 814.93ms slower ❌
2% - 5%
14.04ms - 35.44ms
-

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 646 kB 182.88ms - 184.80ms - faster ✔
4% - 6%
7.22ms - 12.62ms
branch 621 kB 191.24ms - 196.28ms slower ❌
4% - 7%
7.22ms - 12.62ms
-

color-area permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 469 kB 185.09ms - 194.31ms - unsure 🔍
-4% - +2%
-8.62ms - +4.46ms
branch 446 kB 187.15ms - 196.41ms unsure 🔍
-2% - +5%
-4.46ms - +8.62ms
-

color-slider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 471 kB 156.48ms - 163.16ms - unsure 🔍
-5% - +0%
-8.67ms - +0.19ms
branch 448 kB 161.15ms - 166.97ms unsure 🔍
-0% - +5%
-0.19ms - +8.67ms
-

color-wheel permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 472 kB 154.17ms - 160.07ms - unsure 🔍
-5% - +0%
-7.46ms - +0.58ms
branch 449 kB 157.84ms - 163.28ms unsure 🔍
-0% - +5%
-0.58ms - +7.46ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 730 kB 61.72ms - 67.04ms - unsure 🔍
-2% - +7%
-1.02ms - +4.58ms
branch 705 kB 61.74ms - 63.46ms unsure 🔍
-7% - +1%
-4.58ms - +1.02ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 730 kB 710.02ms - 723.42ms - unsure 🔍
-0% - +3%
-0.85ms - +23.41ms
branch 706 kB 695.33ms - 715.55ms unsure 🔍
-3% - +0%
-23.41ms - +0.85ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 657 kB 109.40ms - 113.92ms - faster ✔
4% - 10%
4.46ms - 12.02ms
branch 632 kB 116.88ms - 122.92ms slower ❌
4% - 11%
4.46ms - 12.02ms
-

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 405 kB 52.79ms - 56.33ms - unsure 🔍
-4% - +5%
-2.37ms - +2.65ms
branch 382 kB 52.64ms - 56.20ms unsure 🔍
-5% - +4%
-2.65ms - +2.37ms
-

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 474 kB 82.65ms - 87.27ms - unsure 🔍
-2% - +6%
-1.37ms - +5.29ms
branch 431 kB 80.60ms - 85.40ms unsure 🔍
-6% - +2%
-5.29ms - +1.37ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 428.77ms - 440.87ms - faster ✔
0% - 5%
1.51ms - 20.37ms
branch 471 kB 438.53ms - 452.99ms slower ❌
0% - 5%
1.51ms - 20.37ms
-

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 80.96ms - 86.04ms - unsure 🔍
-6% - +1%
-5.50ms - +1.14ms
branch 397 kB 83.54ms - 87.82ms unsure 🔍
-1% - +7%
-1.14ms - +5.50ms
-

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 539 kB 143.15ms - 150.85ms - faster ✔
6% - 13%
9.53ms - 21.11ms
branch 516 kB 157.99ms - 166.65ms slower ❌
6% - 15%
9.53ms - 21.11ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 787 kB 626.87ms - 644.73ms - slower ❌
1% - 5%
9.02ms - 27.82ms
branch 762 kB 614.45ms - 620.31ms faster ✔
1% - 4%
9.02ms - 27.82ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 791 kB 45.81ms - 46.27ms - faster ✔
4% - 6%
2.05ms - 3.11ms
branch 766 kB 48.14ms - 49.10ms slower ❌
4% - 7%
2.05ms - 3.11ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 780 kB 653.47ms - 662.13ms - slower ❌
4% - 6%
25.05ms - 35.19ms
branch 755 kB 625.05ms - 630.31ms faster ✔
4% - 5%
25.05ms - 35.19ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 577 kB 97.09ms - 105.91ms - slower ❌
4% - 14%
3.67ms - 12.61ms
branch 552 kB 92.64ms - 94.08ms faster ✔
4% - 12%
3.67ms - 12.61ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 536 kB 980.57ms - 1007.03ms - faster ✔
4% - 7%
44.65ms - 76.91ms
branch 512 kB 1045.35ms - 1063.81ms slower ❌
4% - 8%
44.65ms - 76.91ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 396 kB 28.58ms - 31.22ms - faster ✔
3% - 18%
0.91ms - 6.13ms
branch 374 kB 31.17ms - 35.67ms slower ❌
3% - 21%
0.91ms - 6.13ms
-

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 422 kB 57.13ms - 59.87ms - unsure 🔍
-6% - +0%
-3.86ms - +0.26ms
branch 398 kB 58.77ms - 61.83ms unsure 🔍
-0% - +7%
-0.26ms - +3.86ms
-

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 72.46ms - 75.98ms - unsure 🔍
-7% - +1%
-5.67ms - +0.79ms
branch 398 kB 73.95ms - 79.37ms unsure 🔍
-1% - +8%
-0.79ms - +5.67ms
-

sidenav permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 443 kB 339.84ms - 349.44ms - faster ✔
5% - 9%
16.46ms - 33.02ms
branch 420 kB 362.64ms - 376.12ms slower ❌
5% - 10%
16.46ms - 33.02ms
-

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 495 kB 160.39ms - 168.33ms - faster ✔
1% - 7%
1.20ms - 11.40ms
branch 471 kB 167.45ms - 173.87ms slower ❌
1% - 7%
1.20ms - 11.40ms
-

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 747 kB 1874.65ms - 1878.47ms - unsure 🔍
-0% - -0%
-8.17ms - -2.39ms
branch 723 kB 1879.67ms - 1884.01ms unsure 🔍
+0% - +0%
+2.39ms - +8.17ms
-

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 422 kB 33.00ms - 35.68ms - unsure 🔍
-10% - +1%
-3.55ms - +0.31ms
branch 399 kB 34.57ms - 37.35ms unsure 🔍
-1% - +10%
-0.31ms - +3.55ms
-

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 441 kB 196.66ms - 203.34ms - unsure 🔍
-2% - +2%
-4.73ms - +4.53ms
branch 417 kB 196.89ms - 203.31ms unsure 🔍
-2% - +2%
-4.53ms - +4.73ms
-

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 465 kB 28.64ms - 31.36ms - unsure 🔍
-7% - +5%
-2.02ms - +1.62ms
branch 441 kB 28.98ms - 31.42ms unsure 🔍
-5% - +7%
-1.62ms - +2.02ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 672 kB 78.29ms - 82.15ms - slower ❌
9% - 14%
6.24ms - 10.36ms
branch 647 kB 71.19ms - 72.65ms faster ✔
8% - 13%
6.24ms - 10.36ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 548 kB 45.98ms - 47.30ms - faster ✔
10% - 19%
5.10ms - 10.78ms
branch 525 kB 51.82ms - 57.34ms slower ❌
11% - 23%
5.10ms - 10.78ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 672 kB 118.21ms - 126.03ms - unsure 🔍
-3% - +5%
-3.91ms - +6.19ms
branch 647 kB 117.79ms - 124.17ms unsure 🔍
-5% - +3%
-6.19ms - +3.91ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 648 kB 92.48ms - 97.84ms - faster ✔
1% - 8%
1.25ms - 8.11ms
branch 623 kB 97.70ms - 101.98ms slower ❌
1% - 9%
1.25ms - 8.11ms
-

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 447 kB 85.33ms - 90.95ms - faster ✔
2% - 10%
2.01ms - 9.99ms
branch 423 kB 91.31ms - 96.97ms slower ❌
2% - 11%
2.01ms - 9.99ms
-

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 538 kB 173.00ms - 180.40ms - unsure 🔍
-4% - +2%
-6.88ms - +3.84ms
branch 514 kB 174.34ms - 182.10ms unsure 🔍
-2% - +4%
-3.84ms - +6.88ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 544 kB 102.76ms - 109.36ms - unsure 🔍
-8% - +0%
-8.79ms - +0.51ms
branch 520 kB 106.93ms - 113.47ms unsure 🔍
-1% - +8%
-0.51ms - +8.79ms
-

Copy link
Collaborator

@rubencarvalho rubencarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a note to add downstream dummy consumers with different constraints to dry-run our upcoming releases. This would then be caught.
Thank you for fixing!

Copy link
Contributor

@TarunAdobe TarunAdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love such PRs!!

Copy link
Contributor

@Rajdeepc Rajdeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! But sadly this will not work. reactive-controllers lit dependency needs to be pointed to ^3.1.3 since @spectrum-web-components/reactive-controllers 0.42.2 depends on lit ^3.1.3 which means ^2.5.0 || ^3.1.3 will not be not true in this case.

@graynorton
Copy link

reactive-controllers lit dependency needs to be pointed to ^3.1.3

@Rajdeepc, can you provide any detail on why the @spectrum-web-components/reactive-controllers package won't work with Lit 2.5.0?

@Rajdeepc
Copy link
Contributor

Rajdeepc commented Sep 19, 2024

reactive-controllers lit dependency needs to be pointed to ^3.1.3

@Rajdeepc, can you provide any detail on why the @spectrum-web-components/reactive-controllers package won't work with Lit 2.5.0?

My initial findings is that with lit: 2.5.0, storybook 7.x is not supported under @storybook/types. Component preview breaks under S7.

@graynorton
Copy link

My initial findings is that with lit: 2.5.0, storybook 7.x is not supported under @storybook/types. Component preview breaks under S7.

@Rajdeepc Let's try to sync up next week, maybe in the internal discussions meeting on Tuesday. I tried a bunch of things and couldn't identify any failures as a result of making this change, so would be good to compare notes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants