chore: remove progress-circle overBackground property #4750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10886966689Details
💛 - Coveralls |
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromeaction-bar permalinkbasic-test
action-button permalinkbasic-test
action-group permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
alert-banner permalinkbasic-test
alert-dialog permalinkbasic-test
breadcrumbs permalinkbasic-test
button-group permalinkbasic-test
button permalinktest-basic
coachmark permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
contextual-help permalinkbasic-test
dialog permalinkbasic-test
infield-button permalinkbasic-test
menu permalinktest-basic
number-field permalinkbasic-test
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker-button permalinkbasic-test
picker permalinkbasic-test
popover permalinktest-basic
progress-circle permalinkbasic-test
search permalinktest-basic
slider permalinktest-basic
split-button permalinkbasic-test
tags permalinkbasic-test
toast permalinktest-basic
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
truncated permalinkbasic-test
Firefoxaction-bar permalinkbasic-test
action-button permalinkbasic-test
action-group permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
alert-banner permalinkbasic-test
alert-dialog permalinkbasic-test
breadcrumbs permalinkbasic-test
button-group permalinkbasic-test
button permalinktest-basic
coachmark permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
contextual-help permalinkbasic-test
dialog permalinkbasic-test
infield-button permalinkbasic-test
menu permalinktest-basic
number-field permalinkbasic-test
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker-button permalinkbasic-test
picker permalinkbasic-test
popover permalinktest-basic
progress-circle permalinkbasic-test
search permalinktest-basic
slider permalinktest-basic
split-button permalinkbasic-test
tags permalinkbasic-test
toast permalinktest-basic
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
truncated permalinkbasic-test
|
rubencarvalho
changed the base branch from
main
to
ruben/remove-deprecations
rubencarvalho
added
1.0.0
Rajdeepc
approved these changes
Oct 16, 2024
rubencarvalho
merged commit 12a01af
into
ruben/remove-deprecations
54 of 57 checks passed
rubencarvalho
added a commit
that referenced
this pull request
Oct 29, 2024
* chore: remove 'variant' and 'static' attributes from coach-indicator (#4772) * chore: remove split-button component (#4729) * chore: remove banner component (#4723) * chore: remove deprecated badge values (#4742) * chore: remove sp-quick-actions (#4761) * chore: remove popover's dialog property (#4751) * chore: remove thumbnail deprecated sizes (#4760) * chore: remove progress-circle overBackground property (#4750) * chore: remove deprecated 'static' references (#4818) * chore: remove action-button variant property (#4741) * chore: remove 'theme' attribute from sp-theme (#4765) * feat: add 1.0.0 migration guide (#4776)
rubencarvalho
pushed a commit
that referenced
this pull request
Oct 30, 2024
…4829) - feat(styles): add Spectrum 2 styles - feat(icons-workflow): add support for new Spectrum 2 icons (#4747) - feat(icon): add support for Spectrum 2 icons (#4747) - chore: remove pre-1.0.0 deprecations (#4828) - feat(coach-indicator)!: remove 'variant' and 'static' attributes from coach-indicator (#4772) - feat(split-button)!: remove split-button component (#4729) - feat(banner)!: remove banner component (#4723) - feat(badge)!: remove deprecated badge values (#4742) - feat(quick-actions)!: remove sp-quick-actions (#4761) - feat(popover)!: remove popover's dialog property (#4751) - feat(thumbnail)!: remove thumbnail deprecated sizes (#4760) - feat(progress-circle)!: remove progress-circle overBackground property (#4750) - feat(action-button,action-group,action-menu,button,link,meter,progress-bar): remove deprecated 'static' references (#4818) - feat(action-button)!: remove action-button variant property (#4741) - feat(theme)!: remove 'theme' attribute from sp-theme (#4765) - chore: make the spectrum-two theme fully functional (#4859) - chore: add 1.0.0 migration guide (#4776)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the
sp-progress-circleoverBackgroundproperty along with all associated references and dependencies.Related issue(s)
Motivation and context
For the upcoming 1.0.0 release of Spectrum Web Components, we will remove the deprecated components and features.
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.