Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add 'system' context to sp-theme #4755

Merged
merged 16 commits into from
Oct 8, 2024
Merged

chore: add 'system' context to sp-theme #4755

merged 16 commits into from
Oct 8, 2024

Conversation

rubencarvalho
Copy link
Collaborator

@rubencarvalho rubencarvalho commented Sep 16, 2024 •
edited
Loading

Description

This PR adds a systemContext functionality to the <sp-theme> component, enabling descendant components to consume the system context in a reusable manner.

Motivation and context

Added aSystemResolutionController to encapsulate the logic for requesting and receiving the system context.

Updated the sp-theme README with instructions on how to consume the system context using the controller.

How has this been tested?

Integrated these changes in the IconBase on the S2 icon delivery to test its reactivity.
Unit tests WIP.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Base automatically changed from ruben/chore-theme-refactor to main September 17, 2024 13:12
Rajdeepc
Rajdeepc requested changes Sep 25, 2024
View reviewed changes
packages/icon/src/Icon.ts Outdated Show resolved Hide resolved
tools/theme/test/theme-devmode.test.ts Outdated Show resolved Hide resolved
packages/icon/src/Icon.ts Outdated Show resolved Hide resolved
tools/theme/src/Theme.ts Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

@coveralls
Copy link
Collaborator

coveralls commented Sep 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11219537460

Details

  • 156 of 159 (98.11%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 98.202%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/theme/src/Theme.ts 67 70 95.71%
Totals Coverage Status
Change from base Build 11214991073: -0.008%
Covered Lines: 32713
Relevant Lines: 33135
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 228.181 kB 216.427 kB 🏆 217.136 kB
Scripts 57.843 kB 51.964 kB 🏆 52.56 kB
Stylesheet 34.347 kB 30.054 kB 🏆 30.133 kB
Document 6.221 kB 5.453 kB 🏆 5.46 kB
Font 126.946 kB 126.606 kB 🏆 126.632 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Tachometer results

Chrome

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 430 kB 81.05ms - 82.72ms - faster ✔
15% - 18%
14.94ms - 17.36ms
branch 408 kB 97.15ms - 98.91ms slower ❌
18% - 21%
14.94ms - 17.36ms		 -

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 500 kB 51.74ms - 52.78ms - faster ✔
6% - 8%
3.19ms - 4.59ms
branch 478 kB 55.68ms - 56.62ms slower ❌
6% - 9%
3.19ms - 4.59ms		 -

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 561 kB 71.17ms - 72.91ms - faster ✔
12% - 15%
9.42ms - 12.58ms
branch 521 kB 81.72ms - 84.36ms slower ❌
13% - 18%
9.42ms - 12.58ms		 -

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 583 kB 47.89ms - 49.62ms - faster ✔
4% - 9%
1.84ms - 4.67ms
branch 544 kB 50.89ms - 53.13ms slower ❌
4% - 10%
1.84ms - 4.67ms		 -

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 701 kB 140.76ms - 144.04ms - faster ✔
7% - 10%
10.70ms - 16.21ms
branch 662 kB 153.64ms - 158.07ms slower ❌
7% - 11%
10.70ms - 16.21ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 658 kB 68.17ms - 70.12ms - faster ✔
9% - 12%
6.66ms - 9.20ms
branch 619 kB 76.26ms - 77.90ms slower ❌
9% - 13%
6.66ms - 9.20ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 657 kB 66.78ms - 68.16ms - faster ✔
9% - 12%
6.88ms - 9.26ms
branch 618 kB 74.57ms - 76.51ms slower ❌
10% - 14%
6.88ms - 9.26ms		 -

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 847 kB 1873.38ms - 1876.01ms - unsure 🔍
-0% - +0%
-3.60ms - +0.37ms
branch 805 kB 1874.82ms - 1877.79ms unsure 🔍
-0% - +0%
-0.37ms - +3.60ms		 -

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 845 kB 1877.18ms - 1880.34ms - unsure 🔍
-0% - +0%
-3.06ms - +1.14ms
branch 804 kB 1878.34ms - 1881.10ms unsure 🔍
-0% - +0%
-1.14ms - +3.06ms		 -

alert-banner permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 438 kB 12.23ms - 13.14ms - unsure 🔍
-7% - +2%
-0.87ms - +0.26ms
branch 416 kB 12.65ms - 13.33ms unsure 🔍
-2% - +7%
-0.26ms - +0.87ms		 -

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 497 kB 113.10ms - 116.45ms - faster ✔
0% - 3%
0.15ms - 3.64ms
branch 457 kB 116.18ms - 117.16ms slower ❌
0% - 3%
0.15ms - 3.64ms		 -

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 718 kB 530.74ms - 536.31ms - faster ✔
4% - 6%
23.06ms - 31.16ms
branch 679 kB 557.69ms - 563.58ms slower ❌
4% - 6%
23.06ms - 31.16ms		 -

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 489 kB 45.16ms - 46.39ms - faster ✔
5% - 8%
2.28ms - 4.02ms
branch 448 kB 48.31ms - 49.54ms slower ❌
5% - 9%
2.28ms - 4.02ms		 -

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 495 kB 50.77ms - 51.90ms - faster ✔
6% - 9%
3.49ms - 5.30ms
branch 455 kB 55.03ms - 56.43ms slower ❌
7% - 10%
3.49ms - 5.30ms		 -

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 516 kB 38.24ms - 39.55ms - unsure 🔍
-3% - +1%
-1.08ms - +0.36ms
branch 494 kB 38.95ms - 39.56ms unsure 🔍
-1% - +3%
-0.36ms - +1.08ms		 -

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 429 kB 39.78ms - 40.53ms - faster ✔
11% - 14%
5.11ms - 6.28ms
branch 407 kB 45.41ms - 46.29ms slower ❌
13% - 16%
5.11ms - 6.28ms		 -

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 678 kB 92.85ms - 94.95ms - faster ✔
4% - 7%
3.99ms - 6.91ms
branch 636 kB 98.33ms - 100.37ms slower ❌
4% - 7%
3.99ms - 6.91ms		 -

color-area permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 468 kB 127.25ms - 128.17ms - faster ✔
2% - 3%
1.97ms - 3.43ms
branch 446 kB 129.84ms - 130.97ms slower ❌
2% - 3%
1.97ms - 3.43ms		 -

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 501 kB 42.17ms - 43.87ms - faster ✔
6% - 11%
2.93ms - 5.20ms
branch 479 kB 46.34ms - 47.84ms slower ❌
7% - 12%
2.93ms - 5.20ms		 -

color-slider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 471 kB 108.76ms - 109.73ms - faster ✔
1% - 2%
1.16ms - 2.57ms
branch 448 kB 110.59ms - 111.62ms slower ❌
1% - 2%
1.16ms - 2.57ms		 -

color-wheel permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 472 kB 105.75ms - 106.54ms - faster ✔
2% - 3%
1.75ms - 3.41ms
branch 449 kB 108.00ms - 109.46ms slower ❌
2% - 3%
1.75ms - 3.41ms		 -

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 763 kB 38.02ms - 39.31ms - faster ✔
1% - 4%
0.41ms - 1.77ms
branch 720 kB 39.53ms - 39.97ms slower ❌
1% - 5%
0.41ms - 1.77ms		 -

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 763 kB 418.59ms - 424.97ms - faster ✔
1% - 3%
5.05ms - 14.52ms
branch 720 kB 428.06ms - 435.07ms slower ❌
1% - 3%
5.05ms - 14.52ms		 -

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 689 kB 50.72ms - 52.32ms - faster ✔
8% - 11%
4.23ms - 6.21ms
branch 647 kB 56.16ms - 57.33ms slower ❌
8% - 12%
4.23ms - 6.21ms		 -

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 554 kB 80.37ms - 81.25ms - unsure 🔍
-1% - +0%
-1.01ms - +0.14ms
branch 514 kB 80.87ms - 81.62ms unsure 🔍
-0% - +1%
-0.14ms - +1.01ms		 -

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 435 kB 46.73ms - 47.84ms - unsure 🔍
-3% - +0%
-1.67ms - +0.13ms
branch 413 kB 47.34ms - 48.76ms unsure 🔍
-0% - +4%
-0.13ms - +1.67ms		 -

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 404 kB 21.17ms - 21.60ms - unsure 🔍
-2% - +1%
-0.47ms - +0.14ms
branch 383 kB 21.33ms - 21.77ms unsure 🔍
-1% - +2%
-0.14ms - +0.47ms		 -

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 473 kB 41.12ms - 42.85ms - unsure 🔍
-1% - +5%
-0.28ms - +2.20ms
branch 431 kB 40.14ms - 41.92ms unsure 🔍
-5% - +1%
-2.20ms - +0.28ms		 -

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 400 kB 10.31ms - 11.05ms - faster ✔
0% - 9%
0.00ms - 1.03ms
branch 379 kB 10.84ms - 11.56ms unsure 🔍
-0% - +10%
+0.00ms - +1.03ms		 -

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 408 kB 11.37ms - 11.95ms - faster ✔
12% - 18%
1.56ms - 2.43ms
branch 386 kB 13.34ms - 13.98ms slower ❌
13% - 21%
1.56ms - 2.43ms		 -

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 416 kB 15.09ms - 15.38ms - faster ✔
7% - 10%
1.17ms - 1.64ms
branch 393 kB 16.45ms - 16.83ms slower ❌
8% - 11%
1.17ms - 1.64ms		 -

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 224.02ms - 230.61ms - faster ✔
0% - 6%
0.12ms - 13.11ms
branch 472 kB 228.33ms - 239.52ms slower ❌
0% - 6%
0.12ms - 13.11ms		 -

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 420 kB 49.38ms - 50.10ms - faster ✔
5% - 7%
2.36ms - 3.85ms
branch 398 kB 52.19ms - 53.50ms slower ❌
5% - 8%
2.36ms - 3.85ms		 -

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 538 kB 71.42ms - 73.66ms - faster ✔
12% - 15%
9.95ms - 13.09ms
branch 516 kB 82.97ms - 85.16ms slower ❌
14% - 18%
9.95ms - 13.09ms		 -

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 469.64ms - 481.16ms - unsure 🔍
-3% - +0%
-13.36ms - +2.13ms
branch 676 kB 475.83ms - 486.19ms unsure 🔍
-0% - +3%
-2.13ms - +13.36ms		 -

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 822 kB 24.40ms - 24.93ms - faster ✔
8% - 12%
2.06ms - 3.49ms
branch 780 kB 26.77ms - 28.11ms slower ❌
8% - 14%
2.06ms - 3.49ms		 -

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 812 kB 380.64ms - 390.59ms - faster ✔
2% - 5%
6.29ms - 21.57ms
branch 770 kB 393.74ms - 405.34ms slower ❌
2% - 6%
6.29ms - 21.57ms		 -

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 609 kB 43.81ms - 44.72ms - faster ✔
6% - 9%
2.93ms - 4.26ms
branch 566 kB 47.37ms - 48.35ms slower ❌
7% - 10%
2.93ms - 4.26ms		 -

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 428 kB 26.15ms - 26.61ms - faster ✔
12% - 14%
3.53ms - 4.42ms
branch 406 kB 29.97ms - 30.73ms slower ❌
13% - 17%
3.53ms - 4.42ms		 -

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 568 kB 518.96ms - 529.69ms - faster ✔
1% - 4%
7.28ms - 21.77ms
branch 527 kB 533.98ms - 543.72ms slower ❌
1% - 4%
7.28ms - 21.77ms		 -

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 395 kB 11.51ms - 11.70ms - faster ✔
3% - 6%
0.36ms - 0.69ms
branch 374 kB 12.00ms - 12.26ms slower ❌
3% - 6%
0.36ms - 0.69ms		 -

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 29.05ms - 29.64ms - faster ✔
2% - 5%
0.58ms - 1.47ms
branch 399 kB 30.03ms - 30.70ms slower ❌
2% - 5%
0.58ms - 1.47ms		 -

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 420 kB 36.85ms - 37.69ms - faster ✔
1% - 4%
0.24ms - 1.40ms
branch 397 kB 37.69ms - 38.48ms slower ❌
1% - 4%
0.24ms - 1.40ms		 -

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 486 kB 40.22ms - 41.13ms - faster ✔
9% - 12%
3.96ms - 5.47ms
branch 464 kB 44.80ms - 46.00ms slower ❌
10% - 14%
3.96ms - 5.47ms		 -

sidenav permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 442 kB 157.66ms - 160.03ms - faster ✔
9% - 11%
14.94ms - 18.66ms
branch 419 kB 174.21ms - 177.07ms slower ❌
9% - 12%
14.94ms - 18.66ms		 -

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 79.27ms - 80.80ms - faster ✔
3% - 6%
2.58ms - 4.89ms
branch 472 kB 82.91ms - 84.64ms slower ❌
3% - 6%
2.58ms - 4.89ms		 -

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 780 kB 1866.81ms - 1871.25ms - unsure 🔍
-0% - +0%
-3.17ms - +3.10ms
branch 739 kB 1866.85ms - 1871.27ms unsure 🔍
-0% - +0%
-3.10ms - +3.17ms		 -

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 13.49ms - 13.83ms - faster ✔
7% - 10%
1.00ms - 1.56ms
branch 399 kB 14.72ms - 15.16ms slower ❌
7% - 11%
1.00ms - 1.56ms		 -

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 414 kB 14.89ms - 15.27ms - faster ✔
6% - 9%
0.90ms - 1.39ms
branch 391 kB 16.07ms - 16.38ms slower ❌
6% - 9%
0.90ms - 1.39ms		 -

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 545 kB 124.10ms - 126.60ms - faster ✔
7% - 9%
8.85ms - 12.60ms
branch 498 kB 134.67ms - 137.48ms slower ❌
7% - 10%
8.85ms - 12.60ms		 -

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 440 kB 119.06ms - 122.04ms - faster ✔
0% - 3%
0.15ms - 3.88ms
branch 416 kB 121.45ms - 123.69ms slower ❌
0% - 3%
0.15ms - 3.88ms		 -

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 464 kB 12.78ms - 13.06ms - unsure 🔍
-1% - +2%
-0.09ms - +0.27ms
branch 442 kB 12.72ms - 12.94ms unsure 🔍
-2% - +1%
-0.27ms - +0.09ms		 -

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 446 kB 24.59ms - 25.73ms - faster ✔
8% - 14%
2.18ms - 4.15ms
branch 425 kB 27.52ms - 29.13ms slower ❌
9% - 17%
2.18ms - 4.15ms		 -

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 444 kB 27.78ms - 28.38ms - faster ✔
12% - 15%
3.88ms - 4.99ms
branch 422 kB 32.05ms - 32.97ms slower ❌
14% - 18%
3.88ms - 4.99ms		 -

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 618 kB 34.38ms - 34.96ms - faster ✔
3% - 6%
1.18ms - 2.08ms
branch 582 kB 35.95ms - 36.64ms slower ❌
3% - 6%
1.18ms - 2.08ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 579 kB 23.67ms - 24.18ms - faster ✔
7% - 10%
1.77ms - 2.66ms
branch 540 kB 25.78ms - 26.51ms slower ❌
7% - 11%
1.77ms - 2.66ms		 -

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 704 kB 52.95ms - 53.92ms - faster ✔
6% - 8%
3.22ms - 4.68ms
branch 662 kB 56.83ms - 57.93ms slower ❌
6% - 9%
3.22ms - 4.68ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 680 kB 42.76ms - 43.91ms - faster ✔
8% - 11%
3.71ms - 5.28ms
branch 638 kB 47.29ms - 48.37ms slower ❌
8% - 12%
3.71ms - 5.28ms		 -

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 446 kB 39.38ms - 40.32ms - faster ✔
4% - 7%
1.56ms - 3.14ms
branch 422 kB 41.57ms - 42.83ms slower ❌
4% - 8%
1.56ms - 3.14ms		 -

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 568 kB 102.64ms - 103.58ms - faster ✔
1% - 2%
0.78ms - 2.10ms
branch 529 kB 104.09ms - 105.01ms slower ❌
1% - 2%
0.78ms - 2.10ms		 -

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 545 kB 61.42ms - 62.80ms - faster ✔
2% - 6%
1.43ms - 3.74ms
branch 519 kB 63.77ms - 65.62ms slower ❌
2% - 6%
1.43ms - 3.74ms		 -
Firefox

accordion permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 430 kB 167.24ms - 173.48ms - faster ✔
14% - 17%
27.13ms - 34.67ms
branch 408 kB 199.15ms - 203.37ms slower ❌
16% - 21%
27.13ms - 34.67ms		 -

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 500 kB 112.74ms - 117.74ms - faster ✔
5% - 11%
6.50ms - 14.18ms
branch 478 kB 122.67ms - 128.49ms slower ❌
6% - 12%
6.50ms - 14.18ms		 -

action-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 561 kB 156.21ms - 164.31ms - faster ✔
9% - 14%
15.13ms - 25.55ms
branch 521 kB 177.32ms - 183.88ms slower ❌
9% - 16%
15.13ms - 25.55ms		 -

action-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 583 kB 115.46ms - 121.94ms - faster ✔
2% - 9%
2.10ms - 11.70ms
branch 544 kB 122.06ms - 129.14ms slower ❌
2% - 10%
2.10ms - 11.70ms		 -

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 701 kB 287.56ms - 292.80ms - faster ✔
11% - 13%
35.85ms - 44.55ms
branch 662 kB 326.90ms - 333.86ms slower ❌
12% - 15%
35.85ms - 44.55ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 658 kB 141.14ms - 143.94ms - faster ✔
2% - 5%
3.22ms - 7.86ms
branch 619 kB 146.23ms - 149.93ms slower ❌
2% - 6%
3.22ms - 7.86ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 657 kB 133.08ms - 136.76ms - faster ✔
5% - 8%
6.79ms - 12.33ms
branch 618 kB 142.41ms - 146.55ms slower ❌
5% - 9%
6.79ms - 12.33ms		 -

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 847 kB 1889.66ms - 1896.34ms - unsure 🔍
-0% - +0%
-3.05ms - +5.29ms
branch 805 kB 1889.38ms - 1894.38ms unsure 🔍
-0% - +0%
-5.29ms - +3.05ms		 -

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 845 kB 1897.51ms - 1902.93ms - unsure 🔍
-0% - +0%
-4.18ms - +2.58ms
branch 804 kB 1899.01ms - 1903.03ms unsure 🔍
-0% - +0%
-2.58ms - +4.18ms		 -

alert-banner permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 438 kB 28.37ms - 31.35ms - unsure 🔍
-7% - +6%
-2.13ms - +1.69ms
branch 416 kB 28.88ms - 31.28ms unsure 🔍
-6% - +7%
-1.69ms - +2.13ms		 -

alert-dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 497 kB 203.13ms - 209.79ms - unsure 🔍
-3% - +1%
-6.89ms - +2.01ms
branch 457 kB 205.95ms - 211.85ms unsure 🔍
-1% - +3%
-2.01ms - +6.89ms		 -

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 718 kB 805.54ms - 825.34ms - faster ✔
5% - 8%
43.56ms - 67.28ms
branch 679 kB 864.32ms - 877.40ms slower ❌
5% - 8%
43.56ms - 67.28ms		 -

button-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 489 kB 101.10ms - 106.82ms - faster ✔
4% - 12%
4.36ms - 13.36ms
branch 448 kB 109.34ms - 116.30ms slower ❌
4% - 13%
4.36ms - 13.36ms		 -

button permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 495 kB 113.30ms - 117.66ms - faster ✔
8% - 12%
9.59ms - 15.57ms
branch 455 kB 126.01ms - 130.11ms slower ❌
8% - 14%
9.59ms - 15.57ms		 -

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 516 kB 71.93ms - 76.31ms - faster ✔
0% - 7%
0.11ms - 5.13ms
branch 494 kB 75.50ms - 77.98ms slower ❌
0% - 7%
0.11ms - 5.13ms		 -

checkbox permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 429 kB 94.04ms - 99.00ms - faster ✔
5% - 11%
5.12ms - 11.96ms
branch 407 kB 102.70ms - 107.42ms slower ❌
5% - 13%
5.12ms - 11.96ms		 -

coachmark permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 678 kB 189.86ms - 191.94ms - faster ✔
4% - 6%
7.99ms - 11.97ms
branch 636 kB 199.19ms - 202.57ms slower ❌
4% - 6%
7.99ms - 11.97ms		 -

color-area permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 468 kB 187.53ms - 194.67ms - unsure 🔍
-5% - +1%
-9.62ms - +2.14ms
branch 446 kB 190.16ms - 199.52ms unsure 🔍
-1% - +5%
-2.14ms - +9.62ms		 -

color-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 509 kB 78.72ms - 81.08ms - faster ✔
5% - 8%
3.94ms - 7.30ms
branch 487 kB 84.32ms - 86.72ms slower ❌
5% - 9%
3.94ms - 7.30ms		 -

color-slider permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 471 kB 159.43ms - 165.41ms - unsure 🔍
-4% - +1%
-6.08ms - +2.04ms
branch 448 kB 161.69ms - 167.19ms unsure 🔍
-1% - +4%
-2.04ms - +6.08ms		 -

color-wheel permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 472 kB 157.10ms - 165.02ms - unsure 🔍
-3% - +3%
-5.07ms - +4.59ms
branch 449 kB 158.53ms - 164.07ms unsure 🔍
-3% - +3%
-4.59ms - +5.07ms		 -

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 763 kB 61.15ms - 62.93ms - faster ✔
3% - 6%
1.68ms - 4.16ms
branch 720 kB 64.10ms - 65.82ms slower ❌
3% - 7%
1.68ms - 4.16ms		 -

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 763 kB 734.15ms - 745.25ms - slower ❌
0% - 3%
1.87ms - 24.33ms
branch 720 kB 716.84ms - 736.36ms faster ✔
0% - 3%
1.87ms - 24.33ms		 -

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 689 kB 106.78ms - 113.66ms - faster ✔
4% - 12%
4.86ms - 14.50ms
branch 647 kB 116.52ms - 123.28ms slower ❌
4% - 13%
4.86ms - 14.50ms		 -

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 554 kB 120.29ms - 125.63ms - unsure 🔍
-4% - +2%
-5.18ms - +2.58ms
branch 514 kB 121.45ms - 127.07ms unsure 🔍
-2% - +4%
-2.58ms - +5.18ms		 -

field-group permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 435 kB 104.10ms - 110.46ms - unsure 🔍
-6% - +2%
-6.33ms - +1.89ms
branch 413 kB 106.91ms - 112.09ms unsure 🔍
-2% - +6%
-1.89ms - +6.33ms		 -

field-label permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 404 kB 54.20ms - 57.72ms - unsure 🔍
-2% - +7%
-1.32ms - +3.72ms
branch 383 kB 52.96ms - 56.56ms unsure 🔍
-7% - +2%
-3.72ms - +1.32ms		 -

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 473 kB 84.12ms - 88.56ms - unsure 🔍
-5% - +2%
-4.86ms - +1.54ms
branch 431 kB 85.70ms - 90.30ms unsure 🔍
-2% - +6%
-1.54ms - +4.86ms		 -

help-text permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 400 kB 21.26ms - 22.62ms - unsure 🔍
-5% - +3%
-1.09ms - +0.65ms
branch 379 kB 21.61ms - 22.71ms unsure 🔍
-3% - +5%
-0.65ms - +1.09ms		 -

icon permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 408 kB 26.57ms - 28.67ms - faster ✔
7% - 17%
2.20ms - 5.28ms
branch 386 kB 30.23ms - 32.49ms slower ❌
8% - 19%
2.20ms - 5.28ms		 -

infield-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 416 kB 34.17ms - 37.07ms - faster ✔
1% - 11%
0.30ms - 4.06ms
branch 393 kB 36.60ms - 39.00ms slower ❌
1% - 12%
0.30ms - 4.06ms		 -

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 439.08ms - 454.00ms - unsure 🔍
-4% - +0%
-17.48ms - +1.60ms
branch 472 kB 448.53ms - 460.43ms unsure 🔍
-0% - +4%
-1.60ms - +17.48ms		 -

meter permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 420 kB 84.47ms - 88.81ms - unsure 🔍
-6% - +1%
-5.78ms - +1.22ms
branch 398 kB 86.17ms - 91.67ms unsure 🔍
-1% - +7%
-1.22ms - +5.78ms		 -

number-field permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 538 kB 148.12ms - 154.20ms - faster ✔
12% - 17%
20.97ms - 30.03ms
branch 516 kB 173.30ms - 180.02ms slower ❌
14% - 20%
20.97ms - 30.03ms		 -

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 819 kB 657.26ms - 674.66ms - slower ❌
2% - 5%
13.63ms - 34.09ms
branch 777 kB 636.73ms - 647.47ms faster ✔
2% - 5%
13.63ms - 34.09ms		 -

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 822 kB 48.62ms - 49.26ms - faster ✔
6% - 9%
3.17ms - 4.83ms
branch 780 kB 52.18ms - 53.70ms slower ❌
6% - 10%
3.17ms - 4.83ms		 -

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 812 kB 671.01ms - 677.87ms - slower ❌
3% - 4%
19.10ms - 28.14ms
branch 770 kB 647.88ms - 653.76ms faster ✔
3% - 4%
19.10ms - 28.14ms		 -

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 609 kB 91.17ms - 96.59ms - faster ✔
3% - 9%
2.86ms - 9.06ms
branch 566 kB 98.35ms - 101.33ms slower ❌
3% - 10%
2.86ms - 9.06ms		 -

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 428 kB 56.98ms - 61.10ms - faster ✔
4% - 13%
2.69ms - 8.51ms
branch 406 kB 62.59ms - 66.69ms slower ❌
4% - 15%
2.69ms - 8.51ms		 -

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 568 kB 1012.38ms - 1024.86ms - faster ✔
5% - 7%
48.05ms - 77.11ms
branch 527 kB 1068.08ms - 1094.32ms slower ❌
5% - 8%
48.05ms - 77.11ms		 -

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 395 kB 30.13ms - 32.63ms - unsure 🔍
-4% - +8%
-1.32ms - +2.36ms
branch 374 kB 29.52ms - 32.20ms unsure 🔍
-7% - +4%
-2.36ms - +1.32ms		 -

progress-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 58.90ms - 61.66ms - unsure 🔍
-7% - +0%
-4.20ms - +0.16ms
branch 399 kB 60.61ms - 63.99ms unsure 🔍
-0% - +7%
-0.16ms - +4.20ms		 -

radio permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 420 kB 73.76ms - 77.20ms - faster ✔
1% - 7%
0.37ms - 5.67ms
branch 397 kB 76.49ms - 80.51ms slower ❌
0% - 8%
0.37ms - 5.67ms		 -

search permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 486 kB 70.86ms - 74.94ms - faster ✔
10% - 17%
8.29ms - 14.75ms
branch 464 kB 81.91ms - 86.93ms slower ❌
11% - 21%
8.29ms - 14.75ms		 -

sidenav permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 442 kB 342.75ms - 351.81ms - faster ✔
5% - 9%
20.20ms - 33.92ms
branch 419 kB 369.19ms - 379.49ms slower ❌
6% - 10%
20.20ms - 33.92ms		 -

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 163.91ms - 171.45ms - unsure 🔍
-5% - +1%
-8.22ms - +1.66ms
branch 472 kB 167.78ms - 174.14ms unsure 🔍
-1% - +5%
-1.66ms - +8.22ms		 -

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 780 kB 1874.03ms - 1878.13ms - unsure 🔍
-0% - -0%
-7.28ms - -1.64ms
branch 739 kB 1878.61ms - 1882.47ms unsure 🔍
+0% - +0%
+1.64ms - +7.28ms		 -

swatch permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 421 kB 33.21ms - 35.19ms - faster ✔
1% - 9%
0.37ms - 3.35ms
branch 399 kB 34.95ms - 37.17ms slower ❌
1% - 10%
0.37ms - 3.35ms		 -

switch permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 414 kB 35.67ms - 38.13ms - unsure 🔍
-5% - +4%
-1.76ms - +1.60ms
branch 391 kB 35.84ms - 38.12ms unsure 🔍
-4% - +5%
-1.60ms - +1.76ms		 -

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 545 kB 275.15ms - 283.13ms - faster ✔
3% - 6%
8.51ms - 17.73ms
branch 498 kB 289.97ms - 294.55ms slower ❌
3% - 6%
8.51ms - 17.73ms		 -

tabs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 440 kB 199.56ms - 207.08ms - unsure 🔍
-4% - +2%
-8.98ms - +3.34ms
branch 416 kB 201.26ms - 211.02ms unsure 🔍
-2% - +4%
-3.34ms - +8.98ms		 -

tags permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 464 kB 28.97ms - 31.63ms - unsure 🔍
-2% - +9%
-0.63ms - +2.67ms
branch 442 kB 28.30ms - 30.26ms unsure 🔍
-9% - +2%
-2.67ms - +0.63ms		 -

textfield permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 446 kB 47.88ms - 51.16ms - faster ✔
4% - 12%
2.11ms - 6.77ms
branch 425 kB 52.31ms - 55.61ms slower ❌
4% - 14%
2.11ms - 6.77ms		 -

toast permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 444 kB 63.53ms - 68.11ms - faster ✔
5% - 13%
3.71ms - 9.73ms
branch 422 kB 70.59ms - 74.49ms slower ❌
5% - 15%
3.71ms - 9.73ms		 -

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 704 kB 78.21ms - 81.55ms - slower ❌
6% - 11%
4.21ms - 7.95ms
branch 662 kB 72.95ms - 74.65ms faster ✔
5% - 10%
4.21ms - 7.95ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 579 kB 47.43ms - 48.37ms - faster ✔
3% - 8%
1.63ms - 3.97ms
branch 540 kB 49.63ms - 51.77ms slower ❌
3% - 8%
1.63ms - 3.97ms		 -

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 704 kB 128.12ms - 133.08ms - slower ❌
3% - 9%
3.61ms - 10.51ms
branch 662 kB 121.15ms - 125.93ms faster ✔
3% - 8%
3.61ms - 10.51ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 680 kB 90.94ms - 94.82ms - faster ✔
6% - 11%
5.96ms - 11.28ms
branch 638 kB 99.68ms - 103.32ms slower ❌
6% - 12%
5.96ms - 11.28ms		 -

top-nav permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 446 kB 87.51ms - 92.97ms - faster ✔
2% - 11%
2.13ms - 10.31ms
branch 422 kB 93.41ms - 99.51ms slower ❌
2% - 12%
2.13ms - 10.31ms		 -

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 568 kB 169.30ms - 174.94ms - unsure 🔍
-5% - +0%
-9.53ms - +0.45ms
branch 529 kB 172.55ms - 180.77ms unsure 🔍
-0% - +6%
-0.45ms - +9.53ms		 -

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 545 kB 105.04ms - 110.20ms - unsure 🔍
-5% - +1%
-4.95ms - +1.15ms
branch 519 kB 107.90ms - 111.14ms unsure 🔍
-1% - +5%
-1.15ms - +4.95ms		 -

@rubencarvalho rubencarvalho marked this pull request as ready for review September 26, 2024 08:14
@rubencarvalho rubencarvalho requested a review from a team as a code owner September 26, 2024 08:14
Rajdeepc
Rajdeepc reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@Rajdeepc Rajdeepc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Also please add this controller in this README.md and we can land this!

@rubencarvalho rubencarvalho merged commit 328d51e into main Oct 8, 2024
59 of 61 checks passed
@rubencarvalho rubencarvalho deleted the ruben/chore-theme-context branch October 8, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajdeepc Rajdeepc Rajdeepc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rubencarvalho @coveralls @Rajdeepc