Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove sp-quick-actions #4761

Merged
merged 4 commits into from
Oct 16, 2024
Merged

chore: remove sp-quick-actions #4761

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5547091
chore: remove sp-quick-actions
rubencarvalho Sep 16, 2024
baefc4a
chore: merge main
rubencarvalho Oct 15, 2024
fbdff4e
chore: merge main
rubencarvalho Oct 16, 2024
cc2ef3f
chore: merge remove-deprecations branch
rubencarvalho Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions INVENTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ and [Spectrum Web Components](https://opensource.adobe.com/spectrum-web-componen
| popover | ✅ | [📄](https://opensource.adobe.com/spectrum-css/popover.html) | [📄](https://opensource.adobe.com/spectrum-web-components/components/popover) |
| progressbar | ✅ | [📄](https://opensource.adobe.com/spectrum-css/progressbar.html) | [📄](https://opensource.adobe.com/spectrum-web-components/components/progress-bar) |
| progresscircle | ✅ | [📄](https://opensource.adobe.com/spectrum-css/progresscircle.html) | [📄](https://opensource.adobe.com/spectrum-web-components/components/progress-circle) |
| quickaction | | [📄](https://opensource.adobe.com/spectrum-css/quickaction.html) | [📄](https://opensource.adobe.com/spectrum-web-components/components/quick-actions) |
| quickactions | ✅ | | |
| radio | ✅ | [📄](https://opensource.adobe.com/spectrum-css/radio.html) | [📄](https://opensource.adobe.com/spectrum-web-components/components/radio) |
| radiogroup | ✅ | | |
| rating | ✅ | [📄](https://opensource.adobe.com/spectrum-css/rating.html) | ❌ |
Expand Down
12 changes: 6 additions & 6 deletions packages/card/src/Card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import '@spectrum-web-components/asset/sp-asset.js';

import { Checkbox } from '@spectrum-web-components/checkbox/src/Checkbox';
import '@spectrum-web-components/checkbox/sp-checkbox.js';
import '@spectrum-web-components/quick-actions/sp-quick-actions.js';
import '@spectrum-web-components/popover/sp-popover.js';
import '@spectrum-web-components/divider/sp-divider.js';
import cardStyles from './card.css.js';
import headingStyles from '@spectrum-web-components/styles/heading.js';
Expand Down Expand Up @@ -311,8 +311,8 @@ export class Card extends LikeAnchor(
: nothing}
${this.toggles
? html`
<sp-quick-actions
class="quick-actions"
<sp-popover
class="checkbox-toggle"
@pointerdown=${this.stopPropagationOnHref}
>
<sp-checkbox
Expand All @@ -321,17 +321,17 @@ export class Card extends LikeAnchor(
?checked=${this.selected}
tabindex="-1"
></sp-checkbox>
</sp-quick-actions>
</sp-popover>
`
: nothing}
${this.variant === 'quiet' && this.size === 's'
? html`
<sp-quick-actions
<div
class="spectrum-QuickActions actions"
@pointerdown=${this.stopPropagationOnHref}
>
<slot name="actions"></slot>
</sp-quick-actions>
</div>
`
: nothing}
`;
Expand Down
8 changes: 6 additions & 2 deletions packages/card/src/card.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,12 @@ slot[name='description'] {
height: inherit;
}

sp-quick-actions {
z-index: 1;
sp-popover {
align-items: center;
}

.actions {
margin: auto;
}

/**
Expand Down
10 changes: 5 additions & 5 deletions packages/card/src/spectrum-card.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,17 +236,17 @@ governing permissions and limitations under the License.
}

:host([focused]) .actions,
:host([focused]) .quick-actions,
:host([focused]) .checkbox-toggle,
:host([selected]) .actions,
:host([selected]) .quick-actions,
:host([selected]) .checkbox-toggle,
:host(:focus) .actions,
:host(:focus) .quick-actions {
:host(:focus) .checkbox-toggle {
visibility: visible;
opacity: 1;
pointer-events: all;
}

.quick-actions {
.checkbox-toggle {
visibility: hidden;
box-shadow: var(
--mod-card-actions-drop-shadow-x,
Expand Down Expand Up @@ -749,7 +749,7 @@ governing permissions and limitations under the License.
}

:host(:hover) .actions,
:host(:hover) .quick-actions {
:host(:hover) .checkbox-toggle {
visibility: visible;
opacity: 1;
pointer-events: all;
Expand Down
2 changes: 1 addition & 1 deletion packages/card/src/spectrum-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const config = {
converter.classToClass('spectrum-Card-content'),
converter.classToClass(
'spectrum-Card-quickActions',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: lets confirm from css whether there is any change required here or not on the className

Copy link
Collaborator Author

@rubencarvalho rubencarvalho Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let them know of the use of this deprecated component class name and we will be informed if this changes.

'quick-actions'
'checkbox-toggle'
),
converter.classToClass('spectrum-Card-actions'),
converter.classToClass(
Expand Down
47 changes: 47 additions & 0 deletions packages/card/stories/card.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,53 @@ export const Default = (args: StoryArgs): TemplateResult => {
};
Default.args = {};

export const SmallQuiet = (args: StoryArgs): TemplateResult => {
const { onClick } = args;
return html`
<sp-card
heading="Card Heading"
subheading="JPG"
toggles
?horizontal=${args.horizontal}
style="width: 200px;"
href="https://opensource.adobe.com/spectrum-web-components"
variant="quiet"
size="s"
toggles
@click=${(event: Event) => {
const composedTarget = event.composedPath()[0] as HTMLElement;
if (composedTarget.id !== 'like-anchor') return;
event.stopPropagation();
event.preventDefault();
onClick && onClick(event);
}}
>
<div slot="footer">
Footer with a
<sp-link href="https://google.com">link to Google</sp-link>
</div>
<sp-action-menu
label="More Actions"
slot="actions"
placement="bottom-end"
quiet
>
<sp-menu-item>Deselect</sp-menu-item>
<sp-menu-item>Select Inverse</sp-menu-item>
<sp-menu-item>Feather...</sp-menu-item>
<sp-menu-item>Select and Mask...</sp-menu-item>
<sp-menu-divider></sp-menu-divider>
<sp-menu-item>Save Selection</sp-menu-item>
<sp-menu-item disabled>Make Work Path</sp-menu-item>
</sp-action-menu>
<img slot="cover-photo" src=${portrait} alt="Demo Graphic" />
</sp-card>
`;
};
SmallQuiet.argTypes = {
onClick: { action: 'link click' },
};

export const href = (args: StoryArgs): TemplateResult => {
const { onClick } = args;
return html`
Expand Down
1 change: 0 additions & 1 deletion packages/coachmark/src/Coachmark.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import type { CoachmarkItem } from './CoachmarkItem.js';
import '@spectrum-web-components/asset/sp-asset.js';
import '@spectrum-web-components/button/sp-button.js';
import '@spectrum-web-components/button-group/sp-button-group.js';
import '@spectrum-web-components/quick-actions/sp-quick-actions.js';

/**
* @element sp-coachmark
Expand Down
Loading