Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix for flakyness in ci #4762

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: fix for flakyness in ci #4762

wants to merge 2 commits into from

Conversation

Rajdeepc
Copy link
Contributor

Description

Related issue(s)

Motivation and context

How has this been tested?

  • Test case 1

    1. Go here
    2. Do this

  • Test case 2

    1. Go here
    2. Do this

  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@github-actions GitHub Actions
Copy link

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

@coveralls
Copy link
Collaborator

coveralls commented Sep 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10898138643

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.18%
Totals Coverage Status
Change from base Build 10885766528: 0.0%
Covered Lines: 32524
Relevant Lines: 32962
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 226.263 kB 214.489 kB 🏆 214.675 kB
Scripts 55.658 kB 49.868 kB 🏆 50.003 kB
Stylesheet 34.521 kB 30.178 kB 🏆 30.216 kB
Document 6.204 kB 5.434 kB 🏆 5.438 kB
Font 126.91 kB 126.633 kB 126.624 kB 🏆

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

Tachometer results

Chrome

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 501 kB 49.28ms - 50.38ms - faster ✔
3% - 5%
1.29ms - 2.72ms
branch 477 kB 51.39ms - 52.29ms slower ❌
3% - 5%
1.29ms - 2.72ms		 -

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 669 kB 134.58ms - 137.61ms - faster ✔
5% - 8%
7.89ms - 12.00ms
branch 648 kB 144.65ms - 147.43ms slower ❌
6% - 9%
7.89ms - 12.00ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 623 kB 64.22ms - 65.22ms - faster ✔
7% - 9%
4.52ms - 6.08ms
branch 605 kB 69.42ms - 70.61ms slower ❌
7% - 9%
4.52ms - 6.08ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 622 kB 62.33ms - 63.32ms - faster ✔
8% - 10%
5.24ms - 6.81ms
branch 604 kB 68.25ms - 69.45ms slower ❌
8% - 11%
5.24ms - 6.81ms		 -

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 815 kB 1878.26ms - 1881.11ms - unsure 🔍
+0% - +0%
+5.11ms - +9.02ms
branch 791 kB 1871.28ms - 1873.96ms unsure 🔍
-0% - -0%
-9.02ms - -5.11ms		 -

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 813 kB 1874.14ms - 1876.60ms - unsure 🔍
-0% - +0%
-3.24ms - +0.81ms
branch 789 kB 1874.97ms - 1878.19ms unsure 🔍
-0% - +0%
-0.81ms - +3.24ms		 -

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 686 kB 480.52ms - 485.70ms - faster ✔
1% - 2%
4.38ms - 11.79ms
branch 664 kB 488.54ms - 493.85ms slower ❌
1% - 2%
4.38ms - 11.79ms		 -

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 731 kB 36.17ms - 36.55ms - faster ✔
2% - 4%
0.89ms - 1.51ms
branch 705 kB 37.31ms - 37.81ms slower ❌
2% - 4%
0.89ms - 1.51ms		 -

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 732 kB 379.93ms - 384.89ms - faster ✔
2% - 4%
9.75ms - 17.52ms
branch 706 kB 393.06ms - 399.04ms slower ❌
3% - 5%
9.75ms - 17.52ms		 -

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 658 kB 49.16ms - 50.56ms - faster ✔
8% - 13%
4.18ms - 7.20ms
branch 633 kB 54.21ms - 56.89ms slower ❌
8% - 15%
4.18ms - 7.20ms		 -

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 206.78ms - 208.85ms - faster ✔
2% - 4%
4.78ms - 8.14ms
branch 471 kB 212.95ms - 215.60ms slower ❌
2% - 4%
4.78ms - 8.14ms		 -

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 711 kB 426.94ms - 432.36ms - faster ✔
0% - 2%
0.89ms - 7.56ms
branch 687 kB 431.93ms - 435.82ms slower ❌
0% - 2%
0.89ms - 7.56ms		 -

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 792 kB 21.84ms - 22.22ms - faster ✔
9% - 12%
2.31ms - 2.91ms
branch 766 kB 24.40ms - 24.87ms slower ❌
10% - 13%
2.31ms - 2.91ms		 -

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 782 kB 344.75ms - 350.14ms - faster ✔
2% - 5%
6.44ms - 18.07ms
branch 755 kB 354.55ms - 364.85ms slower ❌
2% - 5%
6.44ms - 18.07ms		 -

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 578 kB 40.99ms - 41.72ms - faster ✔
7% - 9%
3.07ms - 4.30ms
branch 552 kB 44.54ms - 45.54ms slower ❌
7% - 10%
3.07ms - 4.30ms		 -

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 536 kB 510.34ms - 518.05ms - faster ✔
3% - 5%
14.38ms - 26.27ms
branch 514 kB 529.99ms - 539.04ms slower ❌
3% - 5%
14.38ms - 26.27ms		 -

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 396 kB 11.05ms - 11.20ms - faster ✔
2% - 4%
0.26ms - 0.51ms
branch 374 kB 11.41ms - 11.61ms slower ❌
2% - 5%
0.26ms - 0.51ms		 -

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 749 kB 1865.14ms - 1869.27ms - unsure 🔍
-0% - +0%
-2.26ms - +3.84ms
branch 724 kB 1864.18ms - 1868.67ms unsure 🔍
-0% - +0%
-3.84ms - +2.26ms		 -

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 566 kB 34.06ms - 35.35ms - faster ✔
2% - 6%
0.80ms - 2.24ms
branch 568 kB 35.90ms - 36.55ms slower ❌
2% - 7%
0.80ms - 2.24ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 548 kB 23.04ms - 23.56ms - faster ✔
6% - 9%
1.50ms - 2.22ms
branch 525 kB 24.91ms - 25.40ms slower ❌
6% - 10%
1.50ms - 2.22ms		 -

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 673 kB 52.34ms - 53.33ms - faster ✔
5% - 7%
2.63ms - 3.93ms
branch 648 kB 55.69ms - 56.53ms slower ❌
5% - 7%
2.63ms - 3.93ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 649 kB 42.32ms - 43.12ms - faster ✔
6% - 9%
2.72ms - 3.96ms
branch 624 kB 45.59ms - 46.54ms slower ❌
6% - 9%
2.72ms - 3.96ms		 -

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 546 kB 57.55ms - 58.23ms - faster ✔
5% - 6%
2.79ms - 3.88ms
branch 520 kB 60.79ms - 61.65ms slower ❌
5% - 7%
2.79ms - 3.88ms		 -
Firefox

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 501 kB 111.49ms - 118.35ms - unsure 🔍
-6% - +2%
-6.65ms - +1.89ms
branch 477 kB 114.75ms - 119.85ms unsure 🔍
-2% - +6%
-1.89ms - +6.65ms		 -

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 669 kB 275.65ms - 278.43ms - faster ✔
11% - 13%
35.96ms - 40.24ms
branch 648 kB 313.50ms - 316.78ms slower ❌
13% - 15%
35.96ms - 40.24ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 623 kB 132.84ms - 135.20ms - unsure 🔍
-2% - +1%
-2.26ms - +0.78ms
branch 605 kB 133.80ms - 135.72ms unsure 🔍
-1% - +2%
-0.78ms - +2.26ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 622 kB 143.46ms - 149.90ms - slower ❌
4% - 10%
5.11ms - 13.13ms
branch 604 kB 135.17ms - 139.95ms faster ✔
4% - 9%
5.11ms - 13.13ms		 -

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 815 kB 1905.91ms - 1913.65ms - slower ❌
1% - 1%
15.82ms - 25.58ms
branch 791 kB 1886.10ms - 1892.06ms faster ✔
1% - 1%
15.82ms - 25.58ms		 -

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 813 kB 1891.55ms - 1897.49ms - unsure 🔍
-0% - +0%
-5.66ms - +2.54ms
branch 789 kB 1893.26ms - 1898.90ms unsure 🔍
-0% - +0%
-2.54ms - +5.66ms		 -

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 686 kB 780.72ms - 795.04ms - faster ✔
1% - 4%
9.00ms - 32.84ms
branch 664 kB 799.27ms - 818.33ms slower ❌
1% - 4%
9.00ms - 32.84ms		 -

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 731 kB 60.87ms - 64.81ms - unsure 🔍
-3% - +4%
-2.08ms - +2.28ms
branch 705 kB 61.81ms - 63.67ms unsure 🔍
-4% - +3%
-2.28ms - +2.08ms		 -

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 732 kB 715.29ms - 737.63ms - slower ❌
1% - 5%
7.90ms - 32.22ms
branch 706 kB 701.58ms - 711.22ms faster ✔
1% - 4%
7.90ms - 32.22ms		 -

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 658 kB 108.90ms - 114.14ms - faster ✔
3% - 9%
3.54ms - 11.34ms
branch 633 kB 116.07ms - 121.85ms slower ❌
3% - 10%
3.54ms - 11.34ms		 -

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 494 kB 428.06ms - 438.82ms - faster ✔
1% - 5%
3.54ms - 24.82ms
branch 471 kB 438.43ms - 456.81ms slower ❌
1% - 6%
3.54ms - 24.82ms		 -

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 789 kB 632.54ms - 648.62ms - slower ❌
2% - 5%
12.38ms - 29.50ms
branch 762 kB 616.70ms - 622.58ms faster ✔
2% - 5%
12.38ms - 29.50ms		 -

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 792 kB 45.92ms - 46.64ms - faster ✔
4% - 7%
2.10ms - 3.34ms
branch 766 kB 48.50ms - 49.50ms slower ❌
5% - 7%
2.10ms - 3.34ms		 -

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 782 kB 653.79ms - 659.09ms - slower ❌
3% - 5%
21.24ms - 28.52ms
branch 755 kB 629.07ms - 634.05ms faster ✔
3% - 4%
21.24ms - 28.52ms		 -

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 578 kB 99.69ms - 108.83ms - slower ❌
6% - 16%
5.97ms - 15.19ms
branch 552 kB 93.01ms - 94.35ms faster ✔
6% - 14%
5.97ms - 15.19ms		 -

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 536 kB 995.65ms - 1021.19ms - faster ✔
4% - 6%
37.46ms - 64.98ms
branch 514 kB 1054.50ms - 1064.78ms slower ❌
4% - 7%
37.46ms - 64.98ms		 -

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 396 kB 26.75ms - 29.17ms - unsure 🔍
-11% - -0%
-3.40ms - +0.00ms
branch 374 kB 28.46ms - 30.86ms unsure 🔍
-0% - +12%
-0.00ms - +3.40ms		 -

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 749 kB 1874.93ms - 1878.67ms - unsure 🔍
-0% - +0%
-3.15ms - +1.91ms
branch 724 kB 1875.71ms - 1879.13ms unsure 🔍
-0% - +0%
-1.91ms - +3.15ms		 -

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 673 kB 79.53ms - 83.63ms - slower ❌
9% - 15%
6.28ms - 10.84ms
branch 648 kB 72.01ms - 74.03ms faster ✔
8% - 13%
6.28ms - 10.84ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 548 kB 46.20ms - 47.60ms - faster ✔
19% - 27%
11.03ms - 17.13ms
branch 525 kB 58.01ms - 63.95ms slower ❌
23% - 37%
11.03ms - 17.13ms		 -

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 673 kB 110.19ms - 116.01ms - faster ✔
4% - 11%
5.25ms - 13.27ms
branch 648 kB 119.61ms - 125.11ms slower ❌
4% - 12%
5.25ms - 13.27ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 649 kB 89.79ms - 93.49ms - faster ✔
6% - 11%
5.96ms - 11.36ms
branch 624 kB 98.34ms - 102.26ms slower ❌
6% - 13%
5.96ms - 11.36ms		 -

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 546 kB 100.72ms - 105.32ms - faster ✔
1% - 8%
0.79ms - 8.85ms
branch 520 kB 104.53ms - 111.15ms slower ❌
1% - 9%
0.79ms - 8.85ms		 -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rajdeepc @coveralls