feat(button): add noWrap property #4779

rubencarvalho · 2024-09-24T15:29:21Z

Description

This PR allows text wrapping within the sp-button, by adding a new noWrap property (no-wrap attribute) to the component and adopting the latest CSS changes.
Added a "Storybook" story with noWrap set.

Related issue(s)

How has this been tested?

Added a screenshot test with the new property toggled.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
If my change required a change to the documentation, I have updated the documentation in this pull request.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

github-actions · 2024-09-24T15:32:10Z

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

coveralls · 2024-09-24T15:36:51Z

Pull Request Test Coverage Report for Build 11175417163

Details

9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 98.21%

Totals
Change from base Build 11142237379:	0.001%
Covered Lines:	32558
Relevant Lines:	32977

💛 - Coveralls

github-actions · 2024-09-24T16:29:33Z

Tachometer results

Chrome

action-bar permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	500 kB	50.01ms - 51.23ms	-	faster ✔ 1% - 6% 0.74ms - 3.33ms
branch	476 kB	51.51ms - 53.80ms	slower ❌ 1% - 7% 0.74ms - 3.33ms	-

action-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	561 kB	66.82ms - 69.14ms	-	faster ✔ 2% - 5% 1.04ms - 3.83ms
branch	520 kB	69.64ms - 71.19ms	slower ❌ 1% - 6% 1.04ms - 3.83ms	-

action-group permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	583 kB	45.51ms - 46.75ms	-	faster ✔ 5% - 9% 2.48ms - 4.61ms
branch	542 kB	48.81ms - 50.54ms	slower ❌ 5% - 10% 2.48ms - 4.61ms	-

action-menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	701 kB	130.87ms - 134.28ms	-	faster ✔ 5% - 8% 6.79ms - 11.53ms
branch	661 kB	140.09ms - 143.37ms	slower ❌ 5% - 9% 6.79ms - 11.53ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	658 kB	63.34ms - 64.49ms	-	faster ✔ 7% - 9% 4.53ms - 6.43ms
branch	617 kB	68.63ms - 70.16ms	slower ❌ 7% - 10% 4.53ms - 6.43ms	-

test-lazy permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	657 kB	62.46ms - 63.64ms	-	faster ✔ 6% - 10% 3.84ms - 6.74ms
branch	616 kB	67.02ms - 69.66ms	slower ❌ 6% - 11% 3.84ms - 6.74ms	-

test-open-close-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	847 kB	1869.25ms - 1872.42ms	-	unsure 🔍 -0% - +0% -2.30ms - +2.00ms
branch	803 kB	1869.53ms - 1872.44ms	unsure 🔍 -0% - +0% -2.00ms - +2.30ms	-

test-open-close permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	845 kB	1872.30ms - 1875.21ms	-	unsure 🔍 -0% - +0% -3.58ms - +0.50ms
branch	802 kB	1873.87ms - 1876.73ms	unsure 🔍 -0% - +0% -0.50ms - +3.58ms	-

alert-banner permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	438 kB	11.43ms - 11.88ms	-	unsure 🔍 -6% - +0% -0.72ms - +0.03ms
branch	415 kB	11.70ms - 12.30ms	unsure 🔍 -0% - +6% -0.03ms - +0.72ms	-

alert-dialog permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	497 kB	106.24ms - 107.64ms	-	faster ✔ 0% - 2% 0.43ms - 2.53ms
branch	456 kB	107.64ms - 109.20ms	slower ❌ 0% - 2% 0.43ms - 2.53ms	-

breadcrumbs permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	718 kB	489.27ms - 497.57ms	-	unsure 🔍 -2% - +0% -9.03ms - +0.97ms
branch	677 kB	494.67ms - 500.24ms	unsure 🔍 -0% - +2% -0.97ms - +9.03ms	-

button-group permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	489 kB	41.01ms - 42.09ms	-	faster ✔ 4% - 7% 1.74ms - 3.33ms
branch	448 kB	43.51ms - 44.67ms	slower ❌ 4% - 8% 1.74ms - 3.33ms	-

button permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	495 kB	45.83ms - 47.06ms	-	faster ✔ 3% - 6% 1.26ms - 2.83ms
branch	454 kB	48.00ms - 48.97ms	slower ❌ 3% - 6% 1.26ms - 2.83ms	-

coachmark permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	678 kB	89.01ms - 91.33ms	-	faster ✔ 5% - 9% 4.65ms - 8.73ms
branch	634 kB	95.19ms - 98.54ms	slower ❌ 5% - 10% 4.65ms - 8.73ms	-

combobox permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	763 kB	36.49ms - 37.22ms	-	faster ✔ 2% - 4% 0.63ms - 1.66ms
branch	718 kB	37.64ms - 38.36ms	slower ❌ 2% - 5% 0.63ms - 1.66ms	-

light-dom-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	763 kB	396.27ms - 401.91ms	-	faster ✔ 0% - 2% 1.83ms - 9.98ms
branch	718 kB	402.06ms - 407.94ms	slower ❌ 0% - 3% 1.83ms - 9.98ms	-

contextual-help permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	689 kB	48.35ms - 49.57ms	-	faster ✔ 5% - 10% 2.62ms - 5.18ms
branch	646 kB	51.73ms - 53.98ms	slower ❌ 5% - 11% 2.62ms - 5.18ms	-

dialog permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	554 kB	76.53ms - 77.92ms	-	unsure 🔍 -1% - +1% -0.96ms - +0.82ms
branch	513 kB	76.73ms - 77.86ms	unsure 🔍 -1% - +1% -0.82ms - +0.96ms	-

infield-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	416 kB	14.19ms - 15.29ms	-	faster ✔ 5% - 14% 0.74ms - 2.26ms
branch	392 kB	15.71ms - 16.77ms	slower ❌ 5% - 16% 0.74ms - 2.26ms	-

menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	494 kB	199.06ms - 202.19ms	-	faster ✔ 1% - 3% 2.19ms - 6.66ms
branch	470 kB	203.45ms - 206.64ms	slower ❌ 1% - 3% 2.19ms - 6.66ms	-

number-field permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	538 kB	64.46ms - 65.82ms	-	faster ✔ 9% - 12% 6.58ms - 8.57ms
branch	515 kB	71.99ms - 73.44ms	slower ❌ 10% - 13% 6.58ms - 8.57ms	-

overlay permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	741 kB	436.20ms - 449.05ms	-	unsure 🔍 -2% - +1% -10.93ms - +2.79ms
branch	700 kB	444.30ms - 449.09ms	unsure 🔍 -1% - +2% -2.79ms - +10.93ms	-

directive-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	822 kB	22.98ms - 23.50ms	-	faster ✔ 6% - 9% 1.48ms - 2.35ms
branch	779 kB	24.81ms - 25.51ms	slower ❌ 6% - 10% 1.48ms - 2.35ms	-

element-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	812 kB	353.24ms - 359.51ms	-	faster ✔ 2% - 4% 6.78ms - 14.91ms
branch	768 kB	364.63ms - 369.81ms	slower ❌ 2% - 4% 6.78ms - 14.91ms	-

lazy-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	609 kB	41.09ms - 41.96ms	-	faster ✔ 5% - 9% 2.29ms - 3.85ms
branch	565 kB	43.95ms - 45.25ms	slower ❌ 5% - 9% 2.29ms - 3.85ms	-

picker-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	428 kB	24.87ms - 25.39ms	-	faster ✔ 4% - 7% 0.97ms - 1.80ms
branch	404 kB	26.19ms - 26.84ms	slower ❌ 4% - 7% 0.97ms - 1.80ms	-

picker permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	568 kB	486.08ms - 491.52ms	-	faster ✔ 2% - 4% 9.15ms - 19.24ms
branch	526 kB	498.74ms - 507.24ms	slower ❌ 2% - 4% 9.15ms - 19.24ms	-

popover permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	395 kB	11.03ms - 11.29ms	-	faster ✔ 2% - 5% 0.24ms - 0.60ms
branch	373 kB	11.46ms - 11.71ms	slower ❌ 2% - 5% 0.24ms - 0.60ms	-

search permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	486 kB	37.92ms - 39.00ms	-	faster ✔ 4% - 7% 1.41ms - 2.72ms
branch	462 kB	40.16ms - 40.90ms	slower ❌ 4% - 7% 1.41ms - 2.72ms	-

slider permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	494 kB	72.95ms - 74.67ms	-	faster ✔ 4% - 7% 3.18ms - 5.59ms
branch	470 kB	77.35ms - 79.04ms	slower ❌ 4% - 8% 3.18ms - 5.59ms	-

split-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	780 kB	1858.84ms - 1862.95ms	-	unsure 🔍 -0% - +0% -5.63ms - +1.35ms
branch	737 kB	1860.22ms - 1865.86ms	unsure 🔍 -0% - +0% -1.35ms - +5.63ms	-

tags permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	464 kB	12.11ms - 12.79ms	-	unsure 🔍 -6% - +2% -0.83ms - +0.27ms
branch	441 kB	12.30ms - 13.16ms	unsure 🔍 -2% - +7% -0.27ms - +0.83ms	-

toast permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	444 kB	26.42ms - 27.00ms	-	faster ✔ 4% - 7% 1.12ms - 2.04ms
branch	421 kB	27.93ms - 28.65ms	slower ❌ 4% - 8% 1.12ms - 2.04ms	-

tooltip permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	622 kB	32.36ms - 33.00ms	-	faster ✔ 5% - 8% 1.79ms - 2.77ms
branch	566 kB	34.60ms - 35.32ms	slower ❌ 5% - 9% 1.79ms - 2.77ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	579 kB	22.33ms - 22.85ms	-	faster ✔ 9% - 12% 2.13ms - 2.99ms
branch	538 kB	24.81ms - 25.49ms	slower ❌ 9% - 13% 2.13ms - 2.99ms	-

test-element permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	704 kB	50.07ms - 51.24ms	-	faster ✔ 4% - 8% 2.38ms - 4.24ms
branch	661 kB	53.25ms - 54.68ms	slower ❌ 5% - 8% 2.38ms - 4.24ms	-

test-lazy permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	680 kB	40.73ms - 41.84ms	-	faster ✔ 6% - 9% 2.68ms - 4.18ms
branch	636 kB	44.20ms - 45.23ms	slower ❌ 6% - 10% 2.68ms - 4.18ms	-

truncated permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	545 kB	57.45ms - 58.58ms	-	faster ✔ 3% - 5% 1.58ms - 3.17ms
branch	519 kB	59.83ms - 60.96ms	slower ❌ 3% - 5% 1.58ms - 3.17ms	-

Firefox

action-bar permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	500 kB	110.54ms - 115.42ms	-	faster ✔ 3% - 9% 3.05ms - 10.35ms
branch	476 kB	116.97ms - 122.39ms	slower ❌ 3% - 9% 3.05ms - 10.35ms	-

action-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	561 kB	149.21ms - 155.95ms	-	faster ✔ 1% - 6% 0.79ms - 9.09ms
branch	520 kB	155.09ms - 159.95ms	slower ❌ 0% - 6% 0.79ms - 9.09ms	-

action-group permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	583 kB	112.70ms - 117.54ms	-	faster ✔ 2% - 8% 2.92ms - 10.12ms
branch	542 kB	118.98ms - 124.30ms	slower ❌ 2% - 9% 2.92ms - 10.12ms	-

action-menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	701 kB	276.94ms - 281.58ms	-	faster ✔ 11% - 13% 34.38ms - 41.18ms
branch	661 kB	314.55ms - 319.53ms	slower ❌ 12% - 15% 34.38ms - 41.18ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	658 kB	137.02ms - 139.82ms	-	unsure 🔍 -1% - +2% -0.75ms - +2.99ms
branch	617 kB	136.07ms - 138.53ms	unsure 🔍 -2% - +1% -2.99ms - +0.75ms	-

test-lazy permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	657 kB	129.86ms - 134.38ms	-	faster ✔ 0% - 5% 0.52ms - 6.64ms
branch	616 kB	133.65ms - 137.75ms	slower ❌ 0% - 5% 0.52ms - 6.64ms	-

test-open-close-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	847 kB	1886.77ms - 1894.55ms	-	unsure 🔍 -0% - +0% -2.28ms - +7.28ms
branch	803 kB	1885.37ms - 1890.95ms	unsure 🔍 -0% - +0% -7.28ms - +2.28ms	-

test-open-close permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	845 kB	1893.72ms - 1900.08ms	-	unsure 🔍 -0% - +0% -6.29ms - +2.05ms
branch	802 kB	1896.33ms - 1901.71ms	unsure 🔍 -0% - +0% -2.05ms - +6.29ms	-

alert-banner permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	438 kB	29.16ms - 31.80ms	-	unsure 🔍 -2% - +9% -0.71ms - +2.59ms
branch	415 kB	28.55ms - 30.53ms	unsure 🔍 -8% - +2% -2.59ms - +0.71ms	-

alert-dialog permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	497 kB	197.99ms - 204.69ms	-	faster ✔ 0% - 5% 0.24ms - 10.68ms
branch	456 kB	202.80ms - 210.80ms	slower ❌ 0% - 5% 0.24ms - 10.68ms	-

breadcrumbs permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	718 kB	785.34ms - 792.62ms	-	faster ✔ 2% - 5% 15.34ms - 38.30ms
branch	677 kB	804.91ms - 826.69ms	slower ❌ 2% - 5% 15.34ms - 38.30ms	-

button-group permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	489 kB	96.87ms - 102.17ms	-	faster ✔ 4% - 11% 3.62ms - 12.18ms
branch	448 kB	104.06ms - 110.78ms	slower ❌ 3% - 12% 3.62ms - 12.18ms	-

button permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	495 kB	108.40ms - 115.16ms	-	unsure 🔍 -7% - +1% -7.91ms - +1.11ms
branch	454 kB	112.19ms - 118.17ms	unsure 🔍 -1% - +7% -1.11ms - +7.91ms	-

coachmark permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	678 kB	186.30ms - 188.10ms	-	faster ✔ 4% - 7% 7.43ms - 13.89ms
branch	634 kB	194.76ms - 200.96ms	slower ❌ 4% - 7% 7.43ms - 13.89ms	-

combobox permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	763 kB	61.44ms - 64.68ms	-	unsure 🔍 -3% - +2% -2.21ms - +1.45ms
branch	718 kB	62.60ms - 64.28ms	unsure 🔍 -2% - +4% -1.45ms - +2.21ms	-

light-dom-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	763 kB	722.99ms - 734.01ms	-	unsure 🔍 -1% - +3% -9.34ms - +18.22ms
branch	718 kB	711.43ms - 736.69ms	unsure 🔍 -2% - +1% -18.22ms - +9.34ms	-

contextual-help permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	689 kB	109.29ms - 114.91ms	-	unsure 🔍 -6% - +1% -7.30ms - +0.70ms
branch	646 kB	112.55ms - 118.25ms	unsure 🔍 -1% - +7% -0.70ms - +7.30ms	-

dialog permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	554 kB	119.47ms - 126.37ms	-	unsure 🔍 -6% - +2% -7.18ms - +2.54ms
branch	513 kB	121.82ms - 128.66ms	unsure 🔍 -2% - +6% -2.54ms - +7.18ms	-

infield-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	416 kB	34.38ms - 37.10ms	-	unsure 🔍 -9% - +0% -3.54ms - +0.14ms
branch	392 kB	36.21ms - 38.67ms	unsure 🔍 -1% - +10% -0.14ms - +3.54ms	-

menu permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	494 kB	430.67ms - 443.97ms	-	faster ✔ 2% - 6% 6.93ms - 26.23ms
branch	470 kB	446.90ms - 460.90ms	slower ❌ 2% - 6% 6.93ms - 26.23ms	-

number-field permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	538 kB	151.89ms - 156.63ms	-	faster ✔ 6% - 10% 10.37ms - 17.71ms
branch	515 kB	165.50ms - 171.10ms	slower ❌ 7% - 12% 10.37ms - 17.71ms	-

overlay permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	819 kB	664.18ms - 686.38ms	-	slower ❌ 3% - 7% 18.72ms - 42.48ms
branch	775 kB	640.44ms - 648.92ms	faster ✔ 3% - 6% 18.72ms - 42.48ms	-

directive-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	822 kB	49.02ms - 50.02ms	-	faster ✔ 4% - 7% 2.05ms - 3.51ms
branch	779 kB	51.77ms - 52.83ms	slower ❌ 4% - 7% 2.05ms - 3.51ms	-

element-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	812 kB	679.31ms - 691.65ms	-	slower ❌ 3% - 6% 21.45ms - 37.43ms
branch	768 kB	650.97ms - 661.11ms	faster ✔ 3% - 5% 21.45ms - 37.43ms	-

lazy-test permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	609 kB	91.37ms - 94.95ms	-	faster ✔ 4% - 9% 4.23ms - 9.33ms
branch	565 kB	98.12ms - 101.76ms	slower ❌ 4% - 10% 4.23ms - 9.33ms	-

picker-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	428 kB	58.05ms - 62.59ms	-	unsure 🔍 -8% - +2% -4.84ms - +1.44ms
branch	404 kB	59.85ms - 64.19ms	unsure 🔍 -2% - +8% -1.44ms - +4.84ms	-

picker permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	568 kB	990.78ms - 1018.26ms	-	faster ✔ 4% - 7% 40.90ms - 71.78ms
branch	526 kB	1053.82ms - 1067.90ms	slower ❌ 4% - 7% 40.90ms - 71.78ms	-

popover permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	395 kB	29.22ms - 32.42ms	-	unsure 🔍 -7% - +6% -2.31ms - +1.95ms
branch	373 kB	29.60ms - 32.40ms	unsure 🔍 -6% - +8% -1.95ms - +2.31ms	-

search permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	486 kB	70.44ms - 74.60ms	-	faster ✔ 3% - 11% 2.18ms - 8.86ms
branch	462 kB	75.43ms - 80.65ms	slower ❌ 3% - 12% 2.18ms - 8.86ms	-

slider permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	494 kB	160.88ms - 167.80ms	-	unsure 🔍 -5% - +0% -9.28ms - +0.24ms
branch	470 kB	165.60ms - 172.12ms	unsure 🔍 -0% - +6% -0.24ms - +9.28ms	-

split-button permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	780 kB	1873.15ms - 1876.81ms	-	faster ✔ 0% - 1% 4.04ms - 10.32ms
branch	737 kB	1879.61ms - 1884.71ms	slower ❌ 0% - 1% 4.04ms - 10.32ms	-

tags permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	464 kB	29.40ms - 31.72ms	-	unsure 🔍 -6% - +5% -1.93ms - +1.49ms
branch	441 kB	29.52ms - 32.04ms	unsure 🔍 -5% - +6% -1.49ms - +1.93ms	-

toast permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	444 kB	62.29ms - 65.83ms	-	faster ✔ 2% - 11% 1.48ms - 7.52ms
branch	421 kB	66.11ms - 71.01ms	slower ❌ 2% - 12% 1.48ms - 7.52ms	-

tooltip permalink

test-basic

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	704 kB	77.24ms - 81.04ms	-	slower ❌ 4% - 10% 3.00ms - 7.64ms
branch	660 kB	72.49ms - 75.15ms	faster ✔ 4% - 10% 3.00ms - 7.64ms	-

test-directive permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	579 kB	46.99ms - 49.09ms	-	faster ✔ 3% - 10% 1.21ms - 5.07ms
branch	538 kB	49.55ms - 52.81ms	slower ❌ 2% - 11% 1.21ms - 5.07ms	-

test-element permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	704 kB	123.86ms - 129.66ms	-	unsure 🔍 -2% - +5% -2.17ms - +6.17ms
branch	661 kB	121.76ms - 127.76ms	unsure 🔍 -5% - +2% -6.17ms - +2.17ms	-

test-lazy permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	680 kB	89.92ms - 93.72ms	-	faster ✔ 6% - 12% 6.15ms - 12.17ms
branch	636 kB	98.65ms - 103.31ms	slower ❌ 7% - 13% 6.15ms - 12.17ms	-

truncated permalink

basic-test

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	545 kB	107.72ms - 112.60ms	-	unsure 🔍 -5% - +2% -5.15ms - +2.47ms
branch	519 kB	108.58ms - 114.42ms	unsure 🔍 -2% - +5% -2.47ms - +5.15ms	-

github-actions · 2024-09-24T17:40:45Z

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.99	0.99	0.99
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category	Latest	Main	Branch
Total	228.369 kB	216.526 kB 🏆	216.89 kB
Scripts	57.393 kB	51.803 kB 🏆	52.247 kB
Stylesheet	34.772 kB	30.287 kB	30.147 kB 🏆
Document	6.238 kB	5.461 kB	5.457 kB 🏆
Font	126.966 kB	126.624 kB 🏆	126.691 kB

Request Count

Category	Latest	Main	Branch
Total	52	52	52
Scripts	41	41	41
Stylesheet	5	5	5
Document	1	1	1
Font	2	2	2

TarunAdobe · 2024-10-03T06:43:52Z

Looks good to me... Can you update the golden image hash and rerun the VRTs? @rubencarvalho ?

TarunAdobe

LGTM! Let's merge this :)

rubencarvalho force-pushed the ruben/button-no-wrap branch from eb0d40b to c7159d8 Compare September 24, 2024 17:31

feat(button): add noWrap property

93edf98

rubencarvalho force-pushed the ruben/button-no-wrap branch from c7159d8 to 93edf98 Compare September 24, 2024 17:32

Merge branch 'main' into ruben/button-no-wrap

3bb8a93

rubencarvalho marked this pull request as ready for review October 2, 2024 13:54

rubencarvalho requested a review from a team as a code owner October 2, 2024 13:54

chore: update golden images cache

b669ba1

rubencarvalho added enhancement New feature or request Component: Button labels Oct 4, 2024

rubencarvalho requested a review from TarunAdobe October 7, 2024 10:49

TarunAdobe approved these changes Oct 7, 2024

View reviewed changes

rubencarvalho merged commit 6760ec2 into main Oct 7, 2024
54 of 61 checks passed

rubencarvalho deleted the ruben/button-no-wrap branch October 7, 2024 11:58

feat(button): add noWrap property #4779

feat(button): add noWrap property #4779

Conversation

rubencarvalho commented Sep 24, 2024 • edited Loading

Description

Related issue(s)

How has this been tested?

Types of changes

Checklist

Best practices

github-actions bot commented Sep 24, 2024

Branch preview

coveralls commented Sep 24, 2024 • edited Loading

Pull Request Test Coverage Report for Build 11175417163

Details

💛 - Coveralls

github-actions bot commented Sep 24, 2024 • edited Loading

Tachometer results

action-bar permalink

basic-test

action-button permalink

basic-test

action-group permalink

basic-test

action-menu permalink

test-basic

test-directive permalink

test-lazy permalink

test-open-close-directive permalink

test-open-close permalink

alert-banner permalink

basic-test

alert-dialog permalink

basic-test

breadcrumbs permalink

basic-test

button-group permalink

basic-test

button permalink

test-basic

coachmark permalink

basic-test

combobox permalink

basic-test

light-dom-test permalink

contextual-help permalink

basic-test

dialog permalink

basic-test

infield-button permalink

basic-test

menu permalink

test-basic

number-field permalink

basic-test

overlay permalink

basic-test

directive-test permalink

element-test permalink

lazy-test permalink

picker-button permalink

basic-test

picker permalink

basic-test

popover permalink

test-basic

search permalink

test-basic

slider permalink

test-basic

split-button permalink

basic-test

tags permalink

basic-test

toast permalink

test-basic

tooltip permalink

test-basic

test-directive permalink

test-element permalink

rubencarvalho commented Sep 24, 2024 •

edited

Loading

coveralls commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading