Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-160879 Add hero-marquee in loadLCPImage #884

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

TsayAdobe
Copy link
Collaborator

  • The old code only checks marquee block. Some pages may use hero-marquee.
  • The image in a hero marquee should have the loading eager attribute.

Resolves: MWPW-160879

Test URLs
Before : http://main--dc--adobecom.hlx.live/acrobat/features/modify-pdfs
After : http://MWPW-160879--dc--adobecom.hlx.live/acrobat/features/modify-pdfs

Copy link

aem-code-sync bot commented Oct 31, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (e906a48) to head (c5bd414).
Report is 3 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #884      +/-   ##
==========================================
- Coverage   84.75%   84.74%   -0.02%     
==========================================
  Files          48       48              
  Lines        6147     6148       +1     
==========================================
  Hits         5210     5210              
- Misses        937      938       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TsayAdobe TsayAdobe merged commit 67a2f43 into stage Nov 4, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants